Restructure AggregationBinder #1378
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gathogojr
force-pushed
the
feature/aggregationbinder-restructure
branch
from
f7eeb2e to
d738dd3
Compare
gathogojr
force-pushed
the
feature/aggregationbinder-restructure
branch
from
d738dd3 to
1e16908
Compare
gathogojr
requested review from
WanjohiSammy,
xuzhg,
marabooy,
KenitoInc,
habbes and
DButoyez
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors
AggregationBinderfor extensibility.The
IAggregationBinderdefines the following 3 methods that need to be implemented:Expression BindGroupBy(TransformationNode, QueryBinderContext)Expression BindSelect(TransformationNode, QueryBinderContext)IQueryable FlattenReferencedProperties(TransformationNode, IQueryable, QueryBinderContext, out ParameterExpression, out IDictionary<SingleValueNode, Expression>The
AggregationBinderimplementsIAggregationBinder. This is the default implementation that is injected into the DI container.The pull request also includes a
TestAggregationBinderdemonstrating how to a custom implementation ofIAggregationBindercan be created and injected into the DI container. In addition, E2E tests have been added to confirm that the default and custom implementations ofIAggregationBinderboth achieve the same result. The E2E tests use an in-memory EF Core database.