Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add create_acl_with_sender syntax sugar #128

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

maurerle
Copy link
Collaborator

this function can be passed as a dict to the send_message, sparing a second receiver_addr argument

I wonder what you think about this, but it adds a lot of comfort instead of having to write the receiver_addr twice.

This would need more documentation and a test or two though.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.62%. Comparing base (b0c1850) to head (ca0b455).

Files with missing lines Patch % Lines
mango/messages/message.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #128      +/-   ##
===============================================
- Coverage        88.65%   88.62%   -0.04%     
===============================================
  Files               22       22              
  Lines             2407     2409       +2     
===============================================
+ Hits              2134     2135       +1     
- Misses             273      274       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

this function can be passed as a dict to the send_message, sparing a second receiver_addr argument
@maurerle maurerle marked this pull request as ready for review December 2, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant