Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set license in pypi metadata to MIT #136

Closed
wants to merge 1 commit into from
Closed

Conversation

maurerle
Copy link
Collaborator

@maurerle maurerle commented Nov 4, 2024

No description provided.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.92%. Comparing base (9fae986) to head (f5bee53).

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #136   +/-   ##
============================================
  Coverage        88.92%   88.92%           
============================================
  Files               22       22           
  Lines             2448     2448           
============================================
  Hits              2177     2177           
  Misses             271      271           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rcschrg
Copy link
Member

rcschrg commented Nov 4, 2024

Why would we switch to text, here? Everything is displayed well on pypi, right? Using the license file like that is in line with the general pyproject guidelines https://packaging.python.org/en/latest/guides/writing-pyproject-toml/

@maurerle
Copy link
Collaborator Author

maurerle commented Nov 4, 2024

Yes, it is fine the way it is right now.
Just thought, that this looks a little distracting:

image

As we have a standard FOSS software license, but we can keep as is, so just close this PR :)

@rcschrg rcschrg closed this Nov 4, 2024
@maurerle maurerle deleted the fix_license branch December 1, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants