Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing parsing of host:port string. #137

Merged
merged 1 commit into from
Nov 9, 2024
Merged

Conversation

rcschrg
Copy link
Member

@rcschrg rcschrg commented Nov 8, 2024

This was problematic if you would use "host:port" notation, save a addr before activating, and then try to send messages with this saved addr. This makes the internal messaging check fail and it will be sent as external message, which is obviously not the point of internal messaging.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.93%. Comparing base (9fae986) to head (f7e7ff4).
Report is 2 commits behind head on development.

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #137   +/-   ##
============================================
  Coverage        88.92%   88.93%           
============================================
  Files               22       22           
  Lines             2448     2449    +1     
============================================
+ Hits              2177     2178    +1     
  Misses             271      271           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rcschrg rcschrg merged commit ed859ce into development Nov 9, 2024
11 checks passed
@maurerle maurerle deleted the fix-internal-messaging branch December 1, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant