Add option to set multiprocessing method through mp_method param in container #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurerle
force-pushed
the
allow_setting_mp_method
branch
from
3eb8ea9 to
f7ef90c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #140 +/- ##
============================================
Coverage 88.97% 88.97%
============================================
Files 22 22
Lines 2457 2459 +2
============================================
+ Hits 2186 2188 +2
Misses 271 271 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
rcschrg
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #139
The deadlock warning looks like it is not needed:
python/cpython#114041 (comment)
Looks like we as well have a pool from which the processes are forked. As long as this is the only part where forking happens, I think we are save..?
The mp_method can be set in the create_tcp_container methods and so on as well