Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve mqtt QoS and return types #143

Merged
merged 1 commit into from
Dec 2, 2024
Merged

improve mqtt QoS and return types #143

merged 1 commit into from
Dec 2, 2024

Conversation

maurerle
Copy link
Collaborator

@maurerle maurerle commented Dec 2, 2024

The return parameter of send_message was used inconsistently.
This is fixed through this PR.

fixes #31

I benchmarked the code a little with the code given in #142 for different QoS and transport methods.
Using the default TCP with default QoS of 0 seems to be the desirable choice.

Note that the QoS of the subscribe side, is used as a maximum QoS supported.

It is desired to use set_tcp_nodelay=true for MQTT brokers to reduce the roundtrip time as noted in #142

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.97%. Comparing base (037f0ec) to head (373ad84).
Report is 3 commits behind head on development.

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #143      +/-   ##
===============================================
- Coverage        88.97%   88.97%   -0.01%     
===============================================
  Files               22       22              
  Lines             2459     2458       -1     
===============================================
- Hits              2188     2187       -1     
  Misses             271      271              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rcschrg rcschrg merged commit f89fd83 into development Dec 2, 2024
10 checks passed
@maurerle maurerle deleted the improve_mqtt branch December 3, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MQTTContainer] pass on mqtt kwargs when external message is sent
2 participants