Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small dyn spn adaptations #1671

Merged
merged 7 commits into from
Jan 10, 2024

Conversation

pat-schmitt
Copy link
Member

@pat-schmitt pat-schmitt commented Jan 10, 2024

Here I am suggesting some changes in the dynamic calibration functions:

  • I changed the default min ice thickness from 10 to 2. I found this in a recent study that with the old default of 10 you are always on the higher end of the target area error boundary. This makes a larger difference for smaller (thinner) glaciers, on the large scale I do not expect to see large differences. Open for discussion! (if we change this should be added to whats-new)
  • I slightly changed the order in the code to avoid wrong diagnostic messages in gdir.get_diagnostics() if something fails. But all functionalities stay the same.
  • I renamed t_bias to t_spinup in the dynamic calibration procedure, to avoid confusion with the temperature bias of the mass balance model (suggestion from @rodaguayo)

@pat-schmitt pat-schmitt merged commit 390f656 into OGGM:master Jan 10, 2024
27 checks passed
@pat-schmitt pat-schmitt deleted the small_dyn_spn_adaptations branch January 29, 2024 08:30
fmaussion pushed a commit to fmaussion/oggm that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant