Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update quoting around labels when adding label #431

Closed
wants to merge 2 commits into from

Conversation

wyardley
Copy link

@wyardley wyardley commented Mar 4, 2025

Fixes #432

@wyardley wyardley requested a review from rdhar as a code owner March 4, 2025 00:02
@wyardley wyardley marked this pull request as draft March 4, 2025 00:04
@rdhar
Copy link
Member

rdhar commented Mar 4, 2025

Hey @wyardley, thanks for the PR!

What does replacing the double-quotes with single-quote do for us exactly?

@wyardley wyardley force-pushed the wyardley/labelsfix branch 2 times, most recently from 3591d90 to a14aacf Compare March 4, 2025 00:17
@wyardley wyardley force-pushed the wyardley/labelsfix branch from a14aacf to 0061d77 Compare March 4, 2025 00:22
@wyardley
Copy link
Author

wyardley commented Mar 4, 2025

What does replacing the double-quotes with single-quote do for us exactly?

Nothing - this is still in draft mode and not yet working.

I thought there was an issue with the [] getting ignored, but that seems to not be the issue. I'm still working on a fix

I looked at using gh pr edit, as you can see in the current state, but ran into this issue, which I'm assuming is why you're using gh api... instead in this action.

I opened the PR here a little prematurely - had meant to get a working fix tested first.

@rdhar rdhar mentioned this pull request Mar 4, 2025
@rdhar
Copy link
Member

rdhar commented Mar 4, 2025

which I'm assuming is why you're using gh api... instead in this action.

Spot-on! Nothing like a years-old quirk, eh, though I could've documented my reasoning better 😅


had meant to get a working fix tested first

No worries at all, you're all good 👍

@rdhar
Copy link
Member

rdhar commented Mar 4, 2025

Within your workflow, are you able to test TF-via-PR with your branch like so:

- name: Provision TF
  uses: op5dev/tf-via-pr@wyardley:wyardley/labelsfix
  ...

@wyardley wyardley closed this Mar 4, 2025
@wyardley wyardley deleted the wyardley/labelsfix branch March 4, 2025 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when labeling PR
2 participants