draft for SSV #468
Open
draft for SSV #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmokstad
reviewed
Apr 28, 2021
akva2
force-pushed
the
draft_ssv
branch
2 times, most recently
from
80b0cc8 to
ca94952
Compare
|
all comments addressed. i also drafted how to handle the want ssv, but no viz, hdf5 file. |
|
The most relevant scenario is perhaps: We want both ssv and viz-files,where viz-file contains "all" results wheres ssv typically contains the most interesting field only (one chosen scalar field + deformations when relevant). |
|
sure, that's trivial to add when we need it, assuming the most interesting fields means 'primary solutions'. |
- remove unused members - use ranged for - remove unnecessary if (we return early if writeData is false)
|
there we go, always only outputting primary solution to ssv file. |
akva2
force-pushed
the
master
branch
6 times, most recently
from
71afb42 to
b4ac149
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.