-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DRSDTCON keyword with regimes and option for GAS/WATER #432
base: main
Are you sure you want to change the base?
Conversation
This reverts commit 7efed90.
I think it would be ok. |
Thanks. |
Added extra parameters to table Changed keyword title Updated description and example
d6ddfc0
to
40f1ea4
Compare
I think all of the conflicts have now been resolved |
Thanks. Let's see what @totto82 has to say. |
Thanks, it mostly looks good. You write: "CHI typically varies from 0.01 - 0.1 depending on reservoir properties. " The way the model is formulated, CHI and PSI are independent on reservoir properties by definition. (Omega is probably not, but also less important). Fine-scale simulations indicates that 0.04+-0.01 are reasonable numbers for CHI. The idea is that the user does not need to do fine-scale simulations themselves but can use the numbers reported in the paper. So 0.04 is a good default and the mean value given in the paper. Where did you get the number 0.01 to 0.1 from? I also notices a spelling mistake "dissoved" |
This came from the previous definition of DRSDTCON in an earlier version of the manual |
@totto82. Thanks for the review. |
Extended DRSDTCON with regimes, and option for GAS/WATER
See OPM/opm-simulators#5491