Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DRSDTCON keyword with regimes and option for GAS/WATER #432

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

gdfldm
Copy link
Collaborator

@gdfldm gdfldm commented Dec 10, 2024

Extended DRSDTCON with regimes, and option for GAS/WATER
See OPM/opm-simulators#5491

@gdfldm gdfldm requested a review from totto82 December 10, 2024 10:35
@blattms
Copy link
Member

blattms commented Dec 13, 2024

We might have a race-condition with #435. If that is merged first this one might have conflicts. Would that be a problem for you @gdfldm?

@gdfldm
Copy link
Collaborator Author

gdfldm commented Dec 13, 2024

Would that be a problem

I think it would be ok.

@blattms
Copy link
Member

blattms commented Jan 3, 2025

Thanks.
Unfortunately, this now needs a rebase.

@gdfldm
Copy link
Collaborator Author

gdfldm commented Jan 3, 2025

this now needs a rebase.

I think all of the conflicts have now been resolved

@blattms
Copy link
Member

blattms commented Jan 3, 2025

Thanks. Let's see what @totto82 has to say.

@totto82
Copy link
Member

totto82 commented Jan 7, 2025

Thanks, it mostly looks good.

You write: "CHI typically varies from 0.01 - 0.1 depending on reservoir properties. "

The way the model is formulated, CHI and PSI are independent on reservoir properties by definition. (Omega is probably not, but also less important). Fine-scale simulations indicates that 0.04+-0.01 are reasonable numbers for CHI. The idea is that the user does not need to do fine-scale simulations themselves but can use the numbers reported in the paper. So 0.04 is a good default and the mean value given in the paper.

Where did you get the number 0.01 to 0.1 from?

I also notices a spelling mistake "dissoved"

@gdfldm
Copy link
Collaborator Author

gdfldm commented Jan 7, 2025

Where did you get the number 0.01 to 0.1 from?

This came from the previous definition of DRSDTCON in an earlier version of the manual

@gdfldm
Copy link
Collaborator Author

gdfldm commented Jan 7, 2025

@totto82. Thanks for the review.
I have removed the typical range, and expanded the discussion of the CHI value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants