Update keyword linking script to handle P603 paragraphs

[hakonhagland]

These paragraphs contain verbatim monospaced text and should not be linked. See #446 (comment) for more information

[gdfldm]

What if LibreOffice changes all of the style numbers?

[blattms]

Maybe in addition detect keywords in a path (between slashes or between slash and dot)?

[hakonhagland]

What if LibreOffice changes all of the style numbers?

@gdfldm Good point. The style P603 is defined like this:

<style:style style:name="P603" style:family="paragraph" style:parent-style-name="Text_20_body">
  <loext:graphic-properties draw:fill="none" draw:fill-gradient-name="gradient" draw:fill-hatch-name="hatch"/>
  <style:paragraph-properties fo:margin-left="0cm" fo:margin-right="0.318cm" fo:margin-top="0cm" fo:margin-bottom="0.051cm" style:contextual-spacing="false" fo:text-align="start" style:justify-single-word="false" fo:orphans="0" fo:widows="0" fo:hyphenation-ladder-count="no-limit" fo:text-indent="0cm" style:auto-text-indent="false" fo:background-color="transparent" style:shadow="none" style:writing-mode="lr-tb"/>
  <style:text-properties style:font-name="Liberation Mono" fo:font-size="8pt" style:font-size-asian="8pt" style:font-size-complex="8pt" fo:hyphenate="false" fo:hyphenation-remain-char-count="2" fo:hyphenation-push-char-count="2" loext:hyphenation-no-caps="false" loext:hyphenation-no-last-word="false" loext:hyphenation-word-char-count="5" loext:hyphenation-zone="no-limit"/>
 </style:style>

The script could search through all automatic-styles and determine if there is one or more styles that has for example:

• style:family="paragraph"
• style:parent-style-name="Text_20_body"
• loext:graphic-properties sub element
• style:text-properties sub element with
  • style:font-name="Liberation Mono"
  • fo:font-size="8pt"

and record the value of style:name (here P603) for such styles, or alternatively we could create a new custom style as we did with the NotKeyword style, and put that in the office:styles section (and not in office:automatic-styles as it is now)

Any other ideas for how to solve this?

[hakonhagland]

and record the value of style:name (here P603) for such styles

I chose to try out this approach first, see latest commit.

[hakonhagland]

Maybe in addition detect keywords in a path (between slashes or between slash and dot)?

@blattms Yes this is a good idea, but I suggest we delay the feature unless we have an explicit case that shows up where it is needed.

[lisajulia]

@hakonhagland: That then means the font size needs to be set to exactly 8pt such that the MonoParagraphStyle is valid, right? How about other font sizes?

[hakonhagland]

Right, the font size might be changed in the future. I suggest we allow any font size to be included in the MonoParagraphStyle

[lisajulia]

I generally approve this PR 👍 :), yet I have one remaining question: #452 (comment), as soon as that is answered, I'm happy to merge this.

[hakonhagland]

@lisajulia Thanks for the review. I have a addressed the comment in the latest commit

[lisajulia]

@lisajulia Thanks for the review. I have a addressed the comment in the latest commit

Thanks :) yet I'm wondering if the check for the font size could be removed overall, since we check if style:font-name is Liberation Mono? Sorry for the nitpicking...

[hakonhagland]

@lisajulia Removed the font size check.