Improving performance and resdata as requirement #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, if a corner-point grid is to be generated using resdata, then the corners are only read once, which significantly reduces the execution time.
Also resdata is set as a requirement now, then for macOS users it is a requirement to use a Python version higher or equal to 3.10 and less than 3.13 (this upper limit also applies for Linux, since there are no packaged version for resdata, thanks to @gassmoeller and @MatthewFlamm for pointing this in #79). This will be mention in the documentation in the following PR.