Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add neighbor skin distance to delay neighbor build #177

Merged
merged 10 commits into from
Apr 1, 2025

Conversation

streeve
Copy link
Collaborator

@streeve streeve commented Jan 21, 2025

Only rebuild contact neighbor list if max displacement exceeds neighbor "skin" distance (the extended cutoff distance)

  • Inputs clarified (PD cutoff vs contact cutoff vs skin extension for contact)
  • Contact models automatically enable the new max displacement calculation during integration and corresponding particle field

Things to consider

  • Should check particles are actually within the cutoff in the force kernel (previously anything in the list was a valid neighbor)

@streeve streeve requested a review from abisner January 21, 2025 16:45
@streeve streeve self-assigned this Jan 21, 2025
@streeve streeve force-pushed the delay_neighbor_builds branch from 7847db1 to 7794e31 Compare January 29, 2025 21:03
@abisner abisner mentioned this pull request Mar 7, 2025
@streeve streeve force-pushed the delay_neighbor_builds branch from 2bd96b5 to 0a11253 Compare March 7, 2025 20:35
@streeve
Copy link
Collaborator Author

streeve commented Mar 7, 2025

@abisner seems to be a real test failure

@streeve streeve force-pushed the delay_neighbor_builds branch from 0a11253 to 0d1ba18 Compare March 12, 2025 22:19
@streeve streeve force-pushed the delay_neighbor_builds branch from 0d1ba18 to 83efda0 Compare March 21, 2025 22:12
@streeve
Copy link
Collaborator Author

streeve commented Mar 27, 2025

@abisner ready for review

@streeve streeve force-pushed the delay_neighbor_builds branch from b242573 to 03c6f2e Compare April 1, 2025 16:23
@streeve streeve enabled auto-merge April 1, 2025 16:23
@streeve streeve merged commit 4a57ba2 into ORNL:main Apr 1, 2025
14 checks passed
@streeve streeve deleted the delay_neighbor_builds branch April 1, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants