-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement real time suggestion #292
Conversation
@Rajgupta36 Thank you for working on this! Could you please resolve existing conflicts before we review this one? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems we can create suggestions index programmatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also noticed multiple loading indicators upon data loading 🤷♂️
yeah it's only when our component load first time . i have fixed it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems we can create suggestions index programmatically.
So what about the index settings, do we need to update them manually?
We need new indexes for query suggestions. we can add facet values programmatically. I think we can create query suggestion indexes for a single user and then update it, just like we used to update the local_issues and other indexes via make load-data or make index-data command. |
backend/apps/common/management/commands/add_suggestion_index.py
Outdated
Show resolved
Hide resolved
backend/apps/common/management/commands/add_suggestion_index.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address these and let's merge it:
backend/tests/common/management/commands/algolia_update_synonyms_tests.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves #148
Implemented real-time suggestions using the autocomplete.js library provided by Algolia.
SearchBar
componentPreview
Screen.Recording.2024-12-29.165757.mp4