-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Project Page Sorting #552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't checked out and tested this yet locally, but from the video you posted I'm thinking it would be good to show which sorting is currently applied even when the sorting dropdown is collapsed.
What do you think?
Yeah, we can do that. Currently, I show a tick mark next to the sorting attribute which is applied. If I display the component value, it might increase the size too much and look weird, since each component has a different value length. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also have some suggestions on how the search bar + sorting should look like. Let's deal with that later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though I see a lot of room for improvement for both code and UI (and we'll do it gradually) I'm merging this PR as it's good enough (it's actually great!) for PoC.
Awesome work on nailing Algolia index replicas for exhaustive sorting @Rajgupta36 👍
Thanks sir🫡. |
Resolves #73
Task Progress
sortBy
component (reusable )api
andsearchPageLayout
componentsMedia
06b6-ec89-44ca-9b52-1418dc0e3ccd.mp4