Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Project Page Sorting #552

Merged
merged 12 commits into from
Jan 23, 2025
Merged

Added Project Page Sorting #552

merged 12 commits into from
Jan 23, 2025

Conversation

Rajgupta36
Copy link
Collaborator

@Rajgupta36 Rajgupta36 commented Jan 19, 2025

Resolves #73

Task Progress

  • Added replicas into indexes
  • Added custom ranking to the indexes
  • Created sortBy component (reusable )
  • Customize api and searchPageLayout components
  • Writing test cases

Media

06b6-ec89-44ca-9b52-1418dc0e3ccd.mp4

Copy link
Collaborator

@kasya kasya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't checked out and tested this yet locally, but from the video you posted I'm thinking it would be good to show which sorting is currently applied even when the sorting dropdown is collapsed.
What do you think?

@Rajgupta36
Copy link
Collaborator Author

Rajgupta36 commented Jan 20, 2025

Haven't checked out and tested this yet locally, but from the video you posted I'm thinking it would be good to show which sorting is currently applied even when the sorting dropdown is collapsed. What do you think?

Yeah, we can do that. Currently, I show a tick mark next to the sorting attribute which is applied. If I display the component value, it might increase the size too much and look weird, since each component has a different value length.

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also have some suggestions on how the search bar + sorting should look like. Let's deal with that later.

@Rajgupta36 Rajgupta36 requested review from kasya and arkid15r January 22, 2025 23:39
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though I see a lot of room for improvement for both code and UI (and we'll do it gradually) I'm merging this PR as it's good enough (it's actually great!) for PoC.

Awesome work on nailing Algolia index replicas for exhaustive sorting @Rajgupta36 👍

@arkid15r arkid15r enabled auto-merge January 23, 2025 00:19
@arkid15r arkid15r added this pull request to the merge queue Jan 23, 2025
Merged via the queue into OWASP:main with commit 990cd4d Jan 23, 2025
13 checks passed
@Rajgupta36
Copy link
Collaborator Author

Even though I see a lot of room for improvement for both code and UI (and we'll do it gradually) I'm merging this PR as it's good enough (it's actually great!) for PoC.

Awesome work on nailing Algolia index replicas for exhaustive sorting @Rajgupta36 👍

Thanks sir🫡.

@Rajgupta36 Rajgupta36 deleted the sort_algolia branch January 24, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Project page sorting
3 participants