Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hide issues and releases sections when empty #553

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

asmit27rai
Copy link

Hide Empty Issues and Releases Sections

Description

Modified the ProjectDetailsPage component to conditionally render issues and releases sections only when they contain data. This improves UI clarity by removing empty sections with placeholder text.

Changes

  • Added conditional checks for issues and releases data
  • Wrapped relevant sections in conditional rendering blocks
  • Removed "No recent issues/releases" placeholder messages

Testing

  • Verified sections hide when data arrays are empty
  • Confirmed sections display correctly when data is present
  • Tested with various data combinations to ensure proper rendering

Issue : #550

@asmit27rai
Copy link
Author

@arkid15r Pls Review The PR

Copy link
Collaborator

@kasya kasya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @asmit27rai Could you update you run make check locally and update you PR? Currently checks are failing.

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run pre-commit first in order to get the PR reviewed

@arkid15r arkid15r linked an issue Jan 21, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't show empty block on project details page
3 participants