Port MASTG-TEST-0027: Testing for URL Loading in WebViews (android) #3061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TheDauntless please check the spell checker errors and remember to deprecate the old test and add also the covered_by field example: status: deprecated
covered_by: [MASTG-TEST-0203, MASTG-TEST-0x03] |
|
Good catch. Please review again :) |
titze
reviewed
Feb 19, 2025
| - The `WebViewClient` is missing the `shouldOverrideUrlLoading` or `shouldInterceptRequest` handlers | ||
| - The `shouldOverrideUrlLoading` or `shouldInterceptRequest` handlers do not correctly prevent untrusted data from being loaded in the `WebView` | ||
|
|
||
| If the `WebView` does not have a custom `WebViewClient`, then any navigation event will automatically trigger the default browser. |
There was a problem hiding this comment.
Not sure the last sentence is needed, since the test case is only for webviews with custom clients?
cpholguera
changed the title
Co-authored-by: titze <[email protected]>
Co-authored-by: titze <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If your PR is related to an issue. Please end your PR test with the following line:
This PR closes #2993