Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snap uploads, some work on MacOS notarization #1126

Merged
merged 7 commits into from
Nov 22, 2024
+694 −227
Merged

Snap uploads, some work on MacOS notarization #1126

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a668dd6
move environment to top of jobs
jgadsden Nov 10, 2024
0af04e1
fix for the notarization variables
jgadsden Nov 11, 2024
fb7bf2a
add app bundle ID for MacOS notarization
jgadsden Nov 13, 2024
ae7164b
try appId in MacOS electron builder options
jgadsden Nov 14, 2024
6eb2579
provide appBundleId to packages
jgadsden Nov 14, 2024
da6377e
staple electron-builder to version 24.12.0
jgadsden Nov 20, 2024
3752042
use electron-builder version 24.12.0
jgadsden Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix for the notarization variables
@jgadsden
jgadsden committed Nov 11, 2024
commit 0af04e15a4fed40c0e4e1dbb0521fe7a9fdf746f
9 changes: 5 additions & 4 deletions .github/workflows/release.yaml
View file
Original file line number Diff line number Diff line change
@@ -4,7 +4,8 @@ on:
push:
# only for version 2.x.x releases and release candidates
tags:
- v2.?.?*
- v2.?.?
- v2.?.?-RC?
workflow_dispatch:

env:
@@ -176,13 +177,13 @@ jobs:
needs: [desktop_unit_tests, site_unit_tests]
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# MacOS signing certificate and password, see electron.build/code-signing
# MacOS signing: certificate and password, see electron.build/code-signing
CSC_KEY_PASSWORD: ${{ secrets.MAC_CERTS_PASSWORD }}
CSC_LINK: ${{ secrets.MAC_CERTS }}
# MacOS notarization:
APPLE_ID: ${{ secrets.APPPLE_ID }}
APPLE_ID: ${{ secrets.APPLE_ID }}
APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_APP_SPECIFIC_PASSWORD }}
APPLE_TEAM_ID: ${{ secrets.APPPLE_TEAM_ID }}
APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
defaults:
run:
working-directory: td.vue

Unchanged files with check annotations Beta

View file
Dockerfile
# Builds the docs
# it would be good to swap out imoshtokill/jekyll-bundler and use jekyll/minimal instead
FROM imoshtokill/jekyll-bundler AS build-docs

Check warning on line 40 in Dockerfile

GitHub Actions / Publish to dockerhub

Base image platform does not match expected target platform 

InvalidBaseImagePlatform: Base image imoshtokill/jekyll-bundler was pulled with platform "linux/amd64", expected "linux/arm64" for current build
WORKDIR /td.docs
COPY ./docs/Gemfile* ./
RUN bundle install