-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lambda-like support for callbacks #33
Conversation
Added rich callback support for callbacks. This should still keep most of the uses still working except the ones with spaces in them. Also adding more documentation for the above feature.
Some checks didnt pass because i used the f"{varName=}" syntax for testing. So commenting those lines out!
Huh. the "workflow tests" failed because I used |
Now I remember why I avoided type hinting. It is always changing and not consistent. Your code only works for 3.10 because of the type hinting. |
I would recommend you drop all type hints for now |
see; I wont drop ALL type hinting; I would like to keep some basic type hinting for sure. Again; pushing a commit... |
Removed some type hinting because of runtime errors on older versions of Python.
Made the implementation better, faster, and smaller in size by using a helper function called `parseHelper` which just returns the args and kwargs it recieves.
New docs for the new implementation.
changed camelCase to snake_case for consistency. Also, removed unnecessary functions.
Maintainer asked to not make docs myself.
This commit acknowledges some of @ObaraEmmanuel in pull request ObaraEmmanuel#33
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have polished up the code. It still does not pass some of the lambda tests I have written locally so I will add some more code to resolve this later in the week. I also intend to change for format from funcname arg1 arg2 ... kwarg1=v kwarg2=v ...
to funcname(arg1, arg2,..., kwarg1=v, kwarg2=v, ...)
for easier parsing.
This commit acknowledges some of @ObaraEmmanuel in pull request ObaraEmmanuel#33
Added rich callback support for callbacks. This should still keep most of the uses still working except the ones with spaces in them.
Also adding more documentation for the above feature.
Issues resolved: #32