Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sampling period #145

Merged

Conversation

LouClement
Copy link
Collaborator

Thank you for your comments Callum, that's really helpful.
I'll make sure to work on a different branch.
I've just updated the code accordingly.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

tests/test_plots.py Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@LouClement LouClement left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, well spotted.

@callumrollo callumrollo merged commit 95dca28 into OceanGlidersCommunity:main Nov 29, 2024
10 checks passed
@callumrollo callumrollo mentioned this pull request Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants