Added text to demo and made optics diagnostic more versatile #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! I am just adding things that come to mind and the demo itself should be seen like more of draft than anything. Maybe we should meet up at some point soon to decide how to proceed and how we want things to look like. What do you think? |
callumrollo
requested changes
Jul 11, 2024
| @@ -15,7 +15,7 @@ def test_up_down_bias(): | |||
|
|
|||
| def test_chl(): | |||
| ds = fetchers.load_sample_dataset() | |||
| tools.chl_first_check(ds) | |||
| tools.optics_first_check(ds) | |||
There was a problem hiding this comment.
add some more test cases here! Now that the function is more flexible, it should get more tests
callumrollo
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.