Additional Logging for Flakey Workspace Cleanup Test and removal of Sync over Async while deleting a workspace #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional test logging to try and diagnose flakey behavour.
|
This pull request has been linked to Shortcut Story #66742: Tentacle Flakey Tests. |
| logger.Information("****** CLIENT AND TENTACLE DISPOSE CALLED *****"); | ||
| logger.Information("* Subsequent errors should be ignored *"); | ||
| logger.Information("****** ****** ****** ****** ****** ****** ******"); | ||
| var banner = new StringBuilder(); |
There was a problem hiding this comment.
Slightly easier to read log
| Directory.Exists(startScriptWorkspaceDirectory).Should().BeFalse("Workspace should be naturally cleaned up after completion"); | ||
| runningScriptResult.LogExecuteScriptOutput(Logger); | ||
|
|
||
| runningScriptResult.ScriptExecutionResult.ExitCode.Should().Be(0, "Script should have completed successfully"); |
There was a problem hiding this comment.
Trying to ensure everything works in the test and there is not another side effect causing the test to fail
| @@ -82,11 +82,6 @@ public string ResolvePath(string fileName) | |||
| return path; | |||
| } | |||
|
|
|||
| public void Delete() | |||
There was a problem hiding this comment.
Removing Sync code path that does a Wait on an Async call as we can be fully async now
There was a problem hiding this comment.
Leaving FileSystem.DeleteDirectory sync method as it is used in other places in the tests. Future cleanup task.
nathanwoctopusdeploy
changed the title
| { | ||
| public static class ScriptExecutionResultExtensionMethods | ||
| { | ||
| public static void LogExecuteScriptOutput(this (ScriptExecutionResult ScriptExecutionResult, List<ProcessOutput> ProcessOutput) result, ILogger logger) |
LukeButters
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Adding some more logging to a flakey test
WhenScriptServiceIsRunning_ThenWorkspaceIsNotDeletede.g. https://build.octopushq.com/buildConfiguration/TeamFireAndMotion_OctopusTentacleNet48_SensibleDefaultsChainFullChain/10569176?hideTestsFromDependencies=false&hideProblemsFromDependencies=false&expandBuildTestsSection=true&expandBuildProblemsSection=true&expandBuildDeploymentsSection=falseRemoved a sync call that then did a Wait on an async call as well can be fully async now.
[sc-66742]
How to review this PR
Quality ✔️
Pre-requisites