Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible fix for Execution Timeout issues seen on Build Server #748

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

nathanwoctopusdeploy
Copy link
Contributor

@nathanwoctopusdeploy nathanwoctopusdeploy commented Dec 18, 2023

Background

Possible fix for Execution Timeout issues seen on Build Server

  • Wait.For now requires a specific timeout to avoid waiting for too long / never finishing the wait if the CancellationToken fails to be cancelled
  • IntegrationTest will now attempt to cancel the cancellation token just before the test times out. Nunit does not call TearDown on the test if it times out through the TimeoutAttribute so we end up in a state where the CancellationToken used for test cleanup is not cancelled and things can keep running.

How to review this PR

Quality ✔️

Pre-requisites

  • I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
  • I have considered informing or consulting the right people, according to the ownership map.
  • I have considered appropriate testing for my change.

@nathanwoctopusdeploy nathanwoctopusdeploy marked this pull request as ready for review December 19, 2023 00:06
@nathanwoctopusdeploy nathanwoctopusdeploy requested a review from a team as a code owner December 19, 2023 00:06
@nathanwoctopusdeploy nathanwoctopusdeploy enabled auto-merge (squash) December 19, 2023 00:07
@nathanwoctopusdeploy nathanwoctopusdeploy merged commit da5e475 into main Dec 19, 2023
2 checks passed
@nathanwoctopusdeploy nathanwoctopusdeploy deleted the sast/fix-test-execution-timeout-issues branch December 19, 2023 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants