Force DockerTasks to run with image platform amd64 when running on arm64 arch #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scme0
force-pushed
the
scme/make-build-work-on-apple-silicon
branch
from
21afc42 to
173bbfe
Compare
APErebus
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The nuke build doesn't work correctly on M1 macs because the DockerTasks try and pull an arm64 version of the container which doesn't exist. This change just forces the DockerTasks to use an amd64 version of the container which runs via Rosetta 2 and works correctly.
Results
This only affects builds on machines running on arm64 architecture and all it does is set the
platformoption toamd64.How to review this PR
Quality ✔️
Pre-requisites