Move Octopus.Configuration interfaces and enum into tentacle and update references #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukeButters
reviewed
Jan 16, 2024
| @@ -1,4 +1,3 @@ | |||
| #nullable enable | |||
There was a problem hiding this comment.
Ah yeah I think that was rider deeming it unnecessary but I'll undo that change to keep this PR focused.
LukeButters
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
As part of #project-k8s-agent, I was adding the ability for Tentacle to save and source configuration from a configmap. During this work, I found that the
Octopus.Configurationproject has been merged back intoOctopus.Serverand the repo in github has been archived.Results
This PR just removes the now defunct nuget package and moves the two interfaces and one enum into Tentacle. It's a relatively simple change, but it touches quite a few files to remove the old namespace.
How to review this PR
Quality ✔️
Pre-requisites