Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add data availability docs #1995
base: master
Are you sure you want to change the base?
add data availability docs #1995
Changes from 4 commits
d07e002
44fcf9b
12a78cf
d26e0f0
1398e99
374fece
9f2edf9
5109916
d968949
4eb9753
8e20eb8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to say Data Availability Committee (DAC) instead? It involves the committee as a whole, instead of the individual servers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I'd say "only a cryptographic proof that the data has been stored by the DAC (Data Availability Certificate...)", so it is not confused with other types of proof.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, kind confused here, do you here mean DACert or DAC?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, my comment is a bit confusing, you're right. I meant that the data is stored by the DAC, and the cryptographic proof is the Data Availability Certificate. So the text would read "only a cryptographic proof that the data has been stored by the DAC (Data Availability Certificate, or DACert)...". I think we've introduced the DAC before, so in this case we are just saying that the data is stored by the DAC, and they return the DACert, which is posted to the parent chain.
Let me know if it's clearer now. If not, maybe we can try to find a different way to describe the process 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd remove this paragraph. It doesn't add value to what has already been said, and it says that it somehow relies on a P2P mechanism (not primarily, but still...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I add this paragraph is because I want to say arbitrum sync and process the data by a much more trustless way, but ya, I forget to add this word in, how do you think if we add trustless in this paragraph?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe in the paragraph above that compares Ethereum to Arbitrum: "However, Arbitrum nodes do not primarily rely on a traditional peer-to-peer (P2P) mechanism for syncing their state as many other blockchains do."
What do you think?