Precompile revert test

precompiles/ArbDebug.go

@@ -7,6 +7,7 @@ import (
 	"errors"
 
 	"github.com/ethereum/go-ethereum/common"
+	"github.com/ethereum/go-ethereum/core/vm"
 )
 
 // All calls to this precompile are authorized by the DebugPrecompile wrapper,
@@ -64,3 +65,19 @@ func (con ArbDebug) Panic(c ctx, evm mech) error {
 func (con ArbDebug) LegacyError(c ctx) error {
 	return errors.New("example legacy error")
 }
+
+func (con ArbDebug) RevertPackingOutput(c ctx, evm mech) (uint64, error) {
+	err := c.State.Burner.Burn(5)
+	if err != nil {
+		return 0, err
+	}
+	return 0xffff, nil
+}
+
+func (con ArbDebug) EmulateRevertPackingOutput(c ctx, evm mech) (uint8, error) {
+	err := c.State.Burner.Burn(5)
+	if err != nil {
+		return 0, err
+	}
+	return 0, vm.ErrExecutionReverted
+}

precompiles/precompile_test.go

@@ -188,7 +188,7 @@ func TestPrecompilesPerArbosVersion(t *testing.T) {
 	log.SetDefault(log.NewLogger(glogger))
 
 	expectedNewMethodsPerArbosVersion := map[uint64]int{
-		0:  89,
+		0:  91,
 		5:  3,
 		10: 2,
 		11: 4,

system_tests/precompile_test.go

@@ -11,6 +11,7 @@ import (
 
 	"github.com/ethereum/go-ethereum/accounts/abi/bind"
 	"github.com/ethereum/go-ethereum/common"
+	"github.com/ethereum/go-ethereum/core/vm"
 	"github.com/ethereum/go-ethereum/params"
 	"github.com/offchainlabs/nitro/arbos"
 	"github.com/offchainlabs/nitro/solgen/go/mocksgen"
@@ -125,6 +126,56 @@ func TestPrecompileErrorGasLeft(t *testing.T) {
 	assertNotAllGasConsumed(common.HexToAddress("0xff"), arbDebug.Methods["legacyError"].ID)
 }
 
+func TestPrecompileEmulatedRevert(t *testing.T) {
+	ctx, cancel := context.WithCancel(context.Background())
+	defer cancel()
+
+	builder := NewNodeBuilder(ctx).DefaultConfig(t, false)
+	cleanup := builder.Build(t)
+	defer cleanup()
+
+	auth := builder.L2Info.GetDefaultTransactOpts("Faucet", ctx)
+	_, _, simple, err := mocksgen.DeploySimple(&auth, builder.L2.Client)
+	Require(t, err)
+
+	arbDebug, err := precompilesgen.ArbDebugMetaData.GetAbi()
+	Require(t, err)
+
+	gasEmulRevertPack, err := simple.CheckGasUsed(&bind.CallOpts{Context: ctx}, common.HexToAddress("0xff"), arbDebug.Methods["emulateRevertPackingOutput"].ID)
+	Require(t, err)
+
+	gasRevertPack, err := simple.CheckGasUsed(&bind.CallOpts{Context: ctx}, common.HexToAddress("0xff"), arbDebug.Methods["revertPackingOutput"].ID)
+	Require(t, err)
+
+	if gasRevertPack.Cmp(gasEmulRevertPack) != 0 {
+		Fatal(t, "gasRevert: ", gasRevertPack, " emulated: ", gasEmulRevertPack)
+	}
+
+	_, _, multiCaller, err := mocksgen.DeployMultiCallTest(&auth, builder.L2.Client)
+	Require(t, err)
+
+	checkDebugFuncReverts := func(methodName string) {
+		funcId := arbDebug.Methods[methodName].ID
+		args := argsForMulticall(vm.CALL, common.HexToAddress("0xff"), nil, funcId)
+		// emit event and allow revert
+		args[5] = args[5] | 0xC
+		tx, err := multiCaller.Fallback(&auth, args)
+		Require(t, err)
+		receipt, err := EnsureTxSucceeded(ctx, builder.L2.Client, tx)
+		Require(t, err)
+		if len(receipt.Logs) != 1 {
+			Fatal(t, methodName, " calling from multi got wrong num of logs")
+		}
+		calledEvt, err := multiCaller.ParseCalled(*receipt.Logs[0])
+		Require(t, err)
+		if calledEvt.Success {
+			Fatal(t, methodName, "did not revert")
+		}
+	}
+	checkDebugFuncReverts("revertPackingOutput")
+	checkDebugFuncReverts("emulateRevertPackingOutput")
+}
+
 func TestScheduleArbosUpgrade(t *testing.T) {
 	ctx, cancel := context.WithCancel(context.Background())
 	defer cancel()