Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add retryable expiry system tests #2799

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add retryable expiry system tests #2799

wants to merge 3 commits into from

Conversation

magicxyyz
Copy link
Contributor

@magicxyyz magicxyyz commented Nov 19, 2024 •
edited
Loading

Resolves NIT-2874

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Nov 19, 2024
diegoximenes
diegoximenes previously requested changes Nov 21, 2024
View reviewed changes
system_tests/retryable_test.go Show resolved Hide resolved
@eljobe eljobe requested a review from diegoximenes January 16, 2025 14:31
@eljobe eljobe dismissed diegoximenes’s stale review January 17, 2025 07:52

We decided not to make the change in this PR. Rather, we opened a ticket to revisit the whole test and clean things up later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eljobe eljobe eljobe approved these changes

@gligneul gligneul Awaiting requested review from gligneul

@diegoximenes diegoximenes Awaiting requested review from diegoximenes

Assignees
No one assigned
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magicxyyz @eljobe @diegoximenes