Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More benchmarks in stylus_benchmark #2870

Merged
merged 76 commits into from
Jan 20, 2025
Merged

More benchmarks in stylus_benchmark #2870

merged 76 commits into from
Jan 20, 2025

Conversation

diegoximenes
Copy link
Contributor

@diegoximenes diegoximenes commented Jan 10, 2025

Resolves NIT-3023

  • Adds more WASM instructions to be benchmarked
  • Adds cargo check CI step related to stylus_benchmark
  • Renames exec_program to launch_program_thread
  • Uses random inputs in some instructions. Some instructions, such as popcnt, have different performances for different inputs. We try to avoid input performance bias by calling the same instruction multiple times, and using random inputs. It was observed that multiple benchmark runs of the same scenario have similar running times.
  • Now --help CLI argument shows the possible scenarios that can be benchmarked

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jan 10, 2025
@diegoximenes diegoximenes force-pushed the stylus_bench_improvements branch from 94f9ea1 to fe323f6 Compare January 10, 2025 16:21
@diegoximenes diegoximenes marked this pull request as ready for review January 10, 2025 19:58
Copy link
Member

@eljobe eljobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eljobe eljobe enabled auto-merge January 20, 2025 16:44
@eljobe eljobe merged commit b84847a into master Jan 20, 2025
15 of 16 checks passed
@eljobe eljobe deleted the stylus_bench_improvements branch January 20, 2025 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants