Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add embedded knowledge flow #13246

Merged
merged 10 commits into from
Feb 25, 2025
Merged

feat: add embedded knowledge flow #13246

merged 10 commits into from
Feb 25, 2025

Conversation

anchenyi
Copy link
Contributor

@anchenyi anchenyi commented Feb 20, 2025

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 98.21429% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.31%. Comparing base (e36b843) to head (1aed7d0).
Report is 14 commits behind head on dev.

Files with missing lines Patch % Lines
packages/fx-core/src/core/FxCore.ts 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #13246      +/-   ##
==========================================
+ Coverage   90.28%   90.31%   +0.02%     
==========================================
  Files         603      604       +1     
  Lines       35888    36040     +152     
  Branches     6965     7173     +208     
==========================================
+ Hits        32401    32549     +148     
  Misses       1514     1514              
- Partials     1973     1977       +4     
Files with missing lines Coverage Δ
packages/cli/src/commands/models/add.ts 100.00% <100.00%> (ø)
packages/cli/src/commands/models/addKnowledge.ts 100.00% <100.00%> (ø)
...t/driver/teamsApp/utils/CopilotGptManifestUtils.ts 94.94% <100.00%> (+0.69%) ⬆️
packages/fx-core/src/question/constants.ts 96.37% <100.00%> (-0.17%) ⬇️
packages/fx-core/src/question/create.ts 90.39% <100.00%> (+0.03%) ⬆️
...x-core/src/question/options/AddKnowledgeOptions.ts 100.00% <ø> (ø)
packages/fx-core/src/question/other.ts 89.06% <100.00%> (+0.66%) ⬆️
packages/fx-core/src/core/FxCore.ts 90.01% <90.00%> (+0.17%) ⬆️

... and 8 files with indirect coverage changes

@anchenyi anchenyi force-pushed the anchenyi/add_embeddedkonwledge branch from ba9787d to 22fde9c Compare February 24, 2025 05:57
@anchenyi anchenyi force-pushed the anchenyi/add_embeddedkonwledge branch from 5a73e19 to 8079e7b Compare February 24, 2025 09:06
@anchenyi anchenyi force-pushed the anchenyi/add_embeddedkonwledge branch from 3876708 to 444b248 Compare February 24, 2025 11:31
@anchenyi anchenyi merged commit 52b93e8 into dev Feb 25, 2025
25 checks passed
@anchenyi anchenyi deleted the anchenyi/add_embeddedkonwledge branch February 25, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants