Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(fx-core): split specGenerator to 3 generators #13282

Draft
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

tecton
Copy link
Contributor

@tecton tecton commented Feb 25, 2025

No description provided.

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 91.46341% with 21 lines in your changes missing coverage. Please review.

Project coverage is 90.30%. Comparing base (3cf945f) to head (838aad6).

Files with missing lines Patch % Lines
...core/src/component/generator/openApiSpec/common.ts 92.07% 0 Missing and 8 partials ⚠️
...generator/openApiSpec/declarativeAgentGenerator.ts 85.71% 3 Missing ⚠️
...s/vscode-extension/src/treeview/treeViewCommand.ts 0.00% 3 Missing ⚠️
...enerator/openApiSpec/customEngineAgentGenerator.ts 90.47% 1 Missing and 1 partial ⚠️
...-core/src/component/generator/openApiSpec/kiota.ts 95.55% 1 Missing and 1 partial ⚠️
...generator/openApiSpec/messageExtensionGenerator.ts 90.47% 1 Missing and 1 partial ⚠️
...vscode-extension/src/handlers/lifecycleHandlers.ts 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #13282      +/-   ##
==========================================
- Coverage   90.31%   90.30%   -0.02%     
==========================================
  Files         604      609       +5     
  Lines       36040    36098      +58     
  Branches     6991     7131     +140     
==========================================
+ Hits        32549    32597      +48     
- Misses       1514     1519       +5     
- Partials     1977     1982       +5     
Files with missing lines Coverage Δ
packages/fx-core/src/common/utils.ts 100.00% <100.00%> (ø)
...t/driver/teamsApp/utils/CopilotGptManifestUtils.ts 94.94% <100.00%> (ø)
.../component/generator/copilotExtension/generator.ts 90.24% <ø> (-0.46%) ⬇️
...-core/src/component/generator/generatorProvider.ts 100.00% <100.00%> (ø)
...-core/src/component/generator/openApiSpec/const.ts 100.00% <100.00%> (ø)
...core/src/component/generator/openApiSpec/helper.ts 94.21% <ø> (ø)
packages/fx-core/src/core/FxCore.ts 90.01% <100.00%> (ø)
packages/fx-core/src/index.ts 100.00% <100.00%> (ø)
packages/fx-core/src/question/create.ts 90.39% <100.00%> (ø)
...vscode-extension/src/handlers/lifecycleHandlers.ts 93.20% <83.33%> (ø)
... and 6 more

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant