Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix negative timezone bug introduced when migrating to python 3 #186

Merged

Conversation

peterb-dev
Copy link
Contributor

The timezone's negative sign must be checked against a byte-string, rather than the python 3 unicode string. Way back in 2011 this bug was fixed in what is likely the original sourcecode for Internaldate2epoch(), see: python/cpython#55148

This v1.1 template stands in .github/.

This PR

Add character x [x].

  • I've read the DCO.
  • I've read the Coding Guidelines
  • The relevant informations about the changes stands in the commit message, not here in the message of the pull request.
  • Code changes follow the style of the files they change.
  • Code is tested (provide details).

References

Additional information

The timezone's negative sign must be checked against a byte-string, rather than the python 3 unicode string.
Way back in 2011 this bug was fixed in what is likely the original sourcecode for Internaldate2epoch(), see:
python/cpython#55148
@etbuira
Copy link

etbuira commented Jul 25, 2024

Looks good to me.

@thekix thekix merged commit 07f8d72 into OfflineIMAP:master Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants