Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite default timeout to keep users signed in for 1 year #197

Merged
merged 1 commit into from
May 14, 2022

Conversation

ztbrown
Copy link
Member

@ztbrown ztbrown commented May 14, 2022

Description

#196 from @james-tw

##Scope

Devise login timeout

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@ztbrown
Copy link
Member Author

ztbrown commented May 14, 2022

@dperzanowski is this kosher? Will this have the desired effect? I saw that there is a remember timeout that is 1 year. Maybe the default inactivity timeout is superseding that?

@dperzanowski
Copy link
Collaborator

@ztbrown This should be good. I'm guessing the rememberable was being ignored for users logging in with Google since the devise credentials weren't being used.

@dperzanowski dperzanowski merged commit 505f904 into main May 14, 2022
@patrickwroach patrickwroach deleted the feat-extend-user-sessions branch February 9, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants