-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PlayerPoints Integration #273
Conversation
I don't know if this one was broken, but I did the same to similar lines in this file which fixed them
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, great work on this one 😁
If possible would be cool to add support for this one aswell: And it would also be cool if we can give these after selling fish at the shop ;) |
Unfortunately that plugin doesn't have a repository for its API, so i won't be able to add it right now. I'd recommend asking the dev if there will be a maven repository at some point so this can be done. |
If I may add to this: It would be nice to have both options possible |
Suggested in #271
Due to the way PlayerPoints works, we can only give it ints. Everything I've done here should account for that.
This was designed in a way that should make adding other economy types quite easy, so i might add more if i feel like it / see requests for it.