Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev sx benchmark #106

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Dev sx benchmark #106

wants to merge 23 commits into from

Conversation

nlqq
Copy link
Contributor

@nlqq nlqq commented Aug 13, 2020

refrom the structure of benchmark

Copy link
Collaborator

@ShawnXuan ShawnXuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

目录名字暂时不能改,1. oneflow-document文档里有引用的地方;2. 现在的目录名字也是之前讨论过的
涉及的文件太多了,建议修改后再pr。

@@ -56,7 +56,7 @@ def str2bool(v):
parser.add_argument('--node_ips', type=str_list, default=['192.168.1.13', '192.168.1.14'],
help='nodes ip list for training, devided by ",", length >= num_nodes')

parser.add_argument("--model", type=str, default="resnet50",
parser.add_argument("--model", type=str, default="resnext50",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default还是resnet50吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Contributor Author

@nlqq nlqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

目录名字暂时不能改,1. oneflow-document文档里有引用的地方;2. 现在的目录名字也是之前讨论过的
涉及的文件太多了,建议修改后再pr。

目录名字可以根据情况更新,也可以再次讨论,引用的地方我来一起改掉。
这些文件多半是由于改名带来的变动,但总体是一次修改,需要分多次pr吗?

@@ -56,7 +56,7 @@ def str2bool(v):
parser.add_argument('--node_ips', type=str_list, default=['192.168.1.13', '192.168.1.14'],
help='nodes ip list for training, devided by ",", length >= num_nodes')

parser.add_argument("--model", type=str, default="resnet50",
parser.add_argument("--model", type=str, default="resnext50",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants