Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Variable Validations #18

Merged
merged 9 commits into from
Oct 31, 2023
Merged

Add Variable Validations #18

merged 9 commits into from
Oct 31, 2023

Conversation

kristianiliev1
Copy link
Contributor

TES-236

Description

Added initial validations for some of the variables

Related Issues

TES-236

https://ontotext.atlassian.net/browse/TES-236

Changes

Screenshots (if applicable)

Checklist

  • I have tested these changes thoroughly.
  • My code follows the project's coding style.
  • I have added appropriate comments to my code, especially in complex areas.
  • All new and existing tests passed locally.

@kristianiliev1 kristianiliev1 self-assigned this Oct 19, 2023
@kristianiliev1
Fix mystake with wrong variables
6f1b6c0 
Some variables were mystaken.

TES-236
@kristianiliev1
Fix typo
ce9c8ca 
Fixed a typo with double quotes

TES-236
@kristianiliev1
Fix formating
f9612cd 
terraform fmt to all files to try to fix formating error from CI action

TES-236
mihailradkov
mihailradkov reviewed Oct 20, 2023
View reviewed changes
modules/backup/variables.tf Outdated Show resolved Hide resolved
modules/user_data/variables.tf Outdated Show resolved Hide resolved
modules/vm/variables.tf Outdated Show resolved Hide resolved
yaskoo
yaskoo reviewed Oct 20, 2023
View reviewed changes
modules/backup/variables.tf Outdated Show resolved Hide resolved
modules/dns/variables.tf Outdated Show resolved Hide resolved
modules/user_data/variables.tf Outdated Show resolved Hide resolved
@yaskoo
Copy link
Contributor

yaskoo commented Oct 23, 2023 •
edited
Loading

LGTM, if you don't have anything else to add/implement - remove the draft status, and let's see if @mihailradkov has anything to add.

@kristianiliev1 kristianiliev1 marked this pull request as ready for review October 23, 2023 12:17
kristianiliev1 and others added 2 commits October 25, 2023 11:16
@kristianiliev1
Add validation to all "resource_name_prefix" vars
db2c37b 
Fixed all the validations of variables per Yasen's comment

TES-236
@kristianiliev1
Fix Formating
e8a189a 
TES-236
yaskoo
yaskoo approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@yaskoo yaskoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the branch and we can merge

@kristianiliev1 kristianiliev1 merged commit e96773a into main Oct 31, 2023
2 checks passed
@kristianiliev1 kristianiliev1 deleted the TES-236-Introduce-Validations branch October 31, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihailradkov mihailradkov mihailradkov approved these changes

@yaskoo yaskoo yaskoo approved these changes

Assignees

@kristianiliev1 kristianiliev1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kristianiliev1 @yaskoo @mihailradkov