TES-305 DNS Module #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaskoo
reviewed
Nov 17, 2023
|
Rebase and remove data sources in favor of variables. |
viktor-ribchev
force-pushed
the
TES-305-DNS-Module
branch
2 times, most recently
from
02bd874 to
39b5cab
Compare
Initial commit for DNS module - TES-305 fix formating update half of the comments from the pull request review fix A records for instances changes from comments and fix records TES-305 add changes from comment suggestions remove dns auto register TES-305 add DNS module Initial commit for DNS module - TES-305 fix formating update half of the comments from the pull request review fix A records for instances changes from comments and fix records TES-305 add changes from comment suggestions
Added additional variables
Added script, which creates DNS records based on the attached disk
Changed disk naming to "Disk-$${RESOURCE_GROUP}-$${ZONE_ID}-$${DISK_ORDER}"
Fixed an issue where the attach disk script was failing
viktor-ribchev
force-pushed
the
TES-305-DNS-Module
branch
from
e8fe799 to
0f4d280
Compare
… of Disk name Updated .gitignore removed versions.tf for DNS module Moved the DNS role assignment to Roles module
viktor-ribchev
force-pushed
the
TES-305-DNS-Module
branch
from
001e456 to
4beed49
Compare
mihailradkov
approved these changes
Nov 30, 2023
yaskoo
approved these changes
Dec 1, 2023
Fixed notes fixed indentation
viktor-ribchev
force-pushed
the
TES-305-DNS-Module
branch
from
24c02bc to
cac007c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduced new Private DNS Module
Related Issues
TES-305
Changes
Added Private DNS Module
Added script, which creates DNS records based on the attached disk
Changed disk naming to "Disk-$${RESOURCE_GROUP}-$${ZONE_ID}-$${DISK_ORDER}"
Fixed an issue where the attach disk script was failing
Checklist