TES-358: Added Key Vault NACLs #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihailradkov
force-pushed
the
TES-358-key-vault-security
branch
from
f777e4f to
d3ee86a
Compare
mihailradkov
force-pushed
the
TES-358-key-vault-security
branch
from
d3ee86a to
c7a7d23
Compare
yaskoo
approved these changes
Nov 24, 2023
- Added key vault service endpoints to the gateway and vmss subnets - Configured the key vault with NACLs to restrict the access only to the virtual network and given management CIDRs - Fixed the graphdb password configuration secret to reference the correct value - Organized the backup module - Added the resource name prefix to the custom roles to avoid clashes
mihailradkov
force-pushed
the
TES-358-key-vault-security
branch
from
c7a7d23 to
4451c05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes