TES-363: Cleaned up configuration and security issues #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihailradkov
force-pushed
the
TES-363-clean-issues
branch
from
c7b21e4 to
bed73d8
Compare
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
mihailradkov
force-pushed
the
TES-363-clean-issues
branch
from
bed73d8 to
0e9534a
Compare
viktor-ribchev
approved these changes
Nov 27, 2023
mihailradkov
force-pushed
the
TES-363-clean-issues
branch
from
0e9534a to
6bed286
Compare
Cleaned up issues reported by tflint, tfsec, Trivy and Checkov. - Added content type for the key vault secrets - Disabled VMSS password login - Enabled VMSS encryption at rest - Added networking rules for the storage account to limit the access only from the VMSS subnet and management CIDRs - Changed the default storage account redundancy to ZRS (multi zonal) - Added the latest recommended SSL policy profile - Disabled the public access to the managed disks - Enabled encryption at host for the VMs - Added configurations for key vault purge protection - Disabled the ability for storage blobs to become public - Variables formatting - Replaced tfsec with trivy in the GitHub workflow - Updated the readme
mihailradkov
force-pushed
the
TES-363-clean-issues
branch
2 times, most recently
from
f204f00 to
4738b1b
Compare
|
The SARIF upload to GitHub is hanging for some reason... merging this anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Cleaned up issues reported by tflint, tfsec, Trivy and Checkov.