Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added script which, creates and attaches volumes #5

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Added script which, creates and attaches volumes #5

merged 1 commit into from
Nov 16, 2023

Conversation

viktor-ribchev
Copy link
Contributor

@viktor-ribchev viktor-ribchev commented Nov 8, 2023 •
edited
Loading

Description

Added script which, creates and attaches volumes

The script covers the following scenarios:

  • No disk in AZ - creates and attaches
  • Existing disk in AZ - attaches.
  • 2 instance in one AZ - creates and attaches, if only one disk is present it will create a new one for the new VM instance.

Related Issues

TES-330

Changes

Added attach volume script to the entrypoint.sh.tpl

Screenshots (if applicable)

N/A

Checklist

  • I have tested these changes thoroughly.
  • My code follows the project's coding style.
  • I have added appropriate comments to my code, especially in complex areas.
  • All new and existing tests passed locally.

mihailradkov
mihailradkov reviewed Nov 8, 2023
View reviewed changes
modules/vm/templates/entrypoint.sh.tpl Outdated Show resolved Hide resolved
modules/vm/templates/entrypoint.sh.tpl Outdated Show resolved Hide resolved
modules/vm/templates/entrypoint.sh.tpl Show resolved Hide resolved
modules/vm/templates/entrypoint.sh.tpl Show resolved Hide resolved
@viktor-ribchev viktor-ribchev force-pushed the TES-330_disk_attaching branch 2 times, most recently from efaca78 to 116558f Compare November 10, 2023 11:55
yaskoo
yaskoo reviewed Nov 10, 2023
View reviewed changes
modules/vm/templates/entrypoint.sh.tpl Outdated Show resolved Hide resolved
modules/vm/templates/entrypoint.sh.tpl Outdated Show resolved Hide resolved
modules/vm/templates/entrypoint.sh.tpl Outdated Show resolved Hide resolved
modules/vm/templates/entrypoint.sh.tpl Outdated Show resolved Hide resolved
modules/vm/templates/entrypoint.sh.tpl Outdated Show resolved Hide resolved
modules/vm/templates/entrypoint.sh.tpl Show resolved Hide resolved
modules/vm/templates/entrypoint.sh.tpl Outdated Show resolved Hide resolved
modules/vm/templates/entrypoint.sh.tpl Outdated Show resolved Hide resolved
modules/vm/templates/entrypoint.sh.tpl Show resolved Hide resolved
mihailradkov
mihailradkov reviewed Nov 13, 2023
View reviewed changes
modules/vm/templates/entrypoint.sh.tpl Outdated Show resolved Hide resolved
modules/vm/templates/entrypoint.sh.tpl Outdated Show resolved Hide resolved
modules/vm/templates/entrypoint.sh.tpl Outdated Show resolved Hide resolved
modules/vm/templates/entrypoint.sh.tpl Show resolved Hide resolved
modules/vm/templates/entrypoint.sh.tpl Outdated Show resolved Hide resolved
@viktor-ribchev viktor-ribchev force-pushed the TES-330_disk_attaching branch 2 times, most recently from 2ce2843 to bf53a98 Compare November 16, 2023 07:12
@viktor-ribchev
Added script which, creates and attaches volumes
d92823c 
Set TIER and DISK_SIZE_GB as Terraform variables
@viktor-ribchev viktor-ribchev merged commit 1b481d0 into main Nov 16, 2023
2 checks passed
@viktor-ribchev viktor-ribchev deleted the TES-330_disk_attaching branch November 16, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihailradkov mihailradkov mihailradkov approved these changes

@yaskoo yaskoo yaskoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viktor-ribchev @yaskoo @mihailradkov