[GDB-10856] Added External AGW and context path support #91

kristianiliev1 · 2024-10-03T11:47:16Z

Description

Added the option to start the cluster without Application Gateway

Related Issues

GDB-10856

Changes

New branch since the old one kinda broke

Screenshots (if applicable)

Checklist

I have tested these changes thoroughly.
My code follows the project's coding style.
I have added appropriate comments to my code, especially in complex areas.
All new and existing tests passed locally.

viktor-ribchev · 2024-10-08T04:23:13Z

Fix the name of the MR, should start with the Jira issue

.gitignore

main.tf

viktor-ribchev · 2024-10-08T04:29:40Z

main.tf

@@ -158,6 +158,7 @@ module "tls" {
 # Creates a public IP address and an Application Gateway for forwarding internet traffic to the GraphDB proxies/instances
 module "application_gateway" {
  source = "./modules/gateway"
+  count  = var.disable_agw ? 0 : 1


Follow the formatting of the other modules and leave an empty line between source and count

main.tf

viktor-ribchev · 2024-10-08T04:33:30Z

main.tf


  # App Configuration
  app_configuration_id       = module.appconfig.app_configuration_id
  app_configuration_endpoint = module.appconfig.app_configuration_endpoint

  # GraphDB Configurations
-  graphdb_external_address_fqdn = var.graphdb_external_address_fqdn != null ? var.graphdb_external_address_fqdn : module.application_gateway.public_ip_address_fqdn
+  graphdb_external_address_fqdn = var.graphdb_external_address_fqdn != null ? var.graphdb_external_address_fqdn : (var.disable_agw ? null : module.application_gateway[0].public_ip_address_fqdn)


How does the graphdb.properties file look like when disable_agw is true?

This comment is still valid

When disabled_agw is true, I have added new validations (will push soon). It uses the Frontend public IP address of the external Application Gateway. It also adds the context path if there is one.

I think this will produce wrong graphdb.properties file when using external Application Gateway and graphdb_external_address_fqdn is not provided.

Yes, external fdqn variable is needed. I will add a note that it is required when disabled_agw is used.

I still want to see the outputted graphdb.properties file

variables.tf

modules/gateway/variables.tf

viktor-ribchev · 2024-10-08T04:43:21Z

modules/gateway/variables.tf

@@ -48,13 +48,19 @@ variable "gateway_allowed_address_prefixes" {
  default     = []
 }

-# Application gateway specific configurations
+# Application gateway specific configurations 


remove the trailing whitespace

modules/gateway/outputs.tf

viktor-ribchev · 2024-10-08T04:54:15Z

I didn’t find any instructions in the README for what needs to be done when apg_disable is set to true. What are the steps users should follow to connect to an existing Application Gateway, and what additional configurations are required?

README.md

viktor-ribchev · 2024-10-11T05:48:24Z

README.md

+```
+
+_Post-Deployment Actions:_
+• After applying the Terraform code, you must perform the following steps:


This shouldn't be a bullet

README.md

main.tf

viktor-ribchev · 2024-10-21T06:14:32Z

main.tf


  # App Configuration
  app_configuration_id       = module.appconfig.app_configuration_id
  app_configuration_endpoint = module.appconfig.app_configuration_endpoint

  # GraphDB Configurations
-  graphdb_external_address_fqdn = var.graphdb_external_address_fqdn != null ? var.graphdb_external_address_fqdn : module.application_gateway.public_ip_address_fqdn
+  graphdb_external_address_fqdn = var.graphdb_external_address_fqdn != null ? var.graphdb_external_address_fqdn : (var.disable_agw ? null : module.application_gateway[0].public_ip_address_fqdn)


This comment is still valid

modules/gateway/outputs.tf

viktor-ribchev · 2024-10-21T06:32:03Z

modules/gateway/outputs.tf

 }

+# Gateway Backend Adress Pool ID:
+# Check if application gateway is enabled and private access is true. If both are available, checks for backend adress pool and retrieves the ID of the first one. Otherwise returns Null.
+# If private access is not enabled, if a public gateway exists with a backend address pool and retrieves its ID if present.


If Private access is disabled and there is a Public Gateway, retrieves the first backend address pool ID.

modules/gateway/outputs.tf

modules/gateway/variables.tf

output.tf

README.md

viktor-ribchev · 2024-10-21T11:52:02Z

README.md


-_Example Configuration:_
+Example Configuration:


Why did you remover the bolding
_Example Configuration:_

README.md

viktor-ribchev · 2024-10-21T11:54:56Z

README.md

 graphdb_external_address_fqdn = "your-fqdn-or-ip"
 ```

-_Post-Deployment Actions:_
+Notes:
+-Setting disable_agw to true allows you to use your existing Application Gateway.


Leave a space after -.
disable_agw and true should be in ` quotes
Same for context_path

modules/graphdb/templates/04_gdb_conf_overrides.sh.tpl

viktor-ribchev · 2024-10-21T12:20:58Z

modules/graphdb/variables.tf

@@ -307,7 +307,18 @@ variable "user_supplied_scripts" {
 }

 variable "disable_agw" {
-  description = "Disables the creation of application gateway from the terraform module."
+  description = "Disables the creation of Application Gateway by the terraform module."


terraform > Terraform

will change. ty

viktor-ribchev · 2024-10-21T12:21:23Z

variables.tf

@@ -137,7 +137,7 @@ variable "gateway_enable_private_access" {
 }

 variable "disable_agw" {
-  description = "Disables the creation of application gateway by the terraform module."
+  description = "Disables the creation of Application Gateway by the terraform module."


terraform > Terraform

variables.tf

.gitignore

viktor-ribchev · 2024-10-22T04:20:52Z

CHANGELOG.md

@@ -1,5 +1,13 @@
 # GraphDB Azure Terraform Module Changelog

+## 1.3.4


These updates should not be here if you rebased properly, also you need to update the Changelog with your changes

This is still valid

This is still valid.
Also you need to add a new version with your changes to the CHANGELOG.md

modules/graphdb/templates/04_gdb_conf_overrides.sh.tpl

viktor-ribchev · 2024-10-28T08:57:22Z

Fix the MR name GDB-10856 - Add Variables File change for testing purposes is unclear and it has nothing to do with the changes you are introducing

.gitignore

viktor-ribchev · 2024-10-28T09:18:39Z

CHANGELOG.md

@@ -1,5 +1,13 @@
 # GraphDB Azure Terraform Module Changelog

+## 1.3.4


This is still valid

README.md

main.tf

modules/gateway/main.tf

modules/gateway/outputs.tf

modules/graphdb/variables.tf

variables.tf

viktor-ribchev · 2024-10-28T10:23:14Z

Rebase and squash the commits

simonzhekoff · 2024-11-05T07:14:21Z

Squash the commits

variables.tf

viktor-ribchev · 2024-11-05T08:58:55Z

README.md

+```
+
+_Notes_:
+- Setting `disable_agw` to true allows you to use your existing Application Gateway.


Reword this, Setting disable_agw to true will disable ....

viktor-ribchev · 2024-11-05T09:01:25Z

README.md

+
+_Notes_:
+- Setting `disable_agw` to true allows you to use your existing Application Gateway.
+- When using `disable_agw` you need to set `graphdb_external_adress_fqdn` as well.


When using disable_agw .... > You need to provide graphdb_external_adress_fqdn when disable_agw is set to true

viktor-ribchev · 2024-11-05T09:04:19Z

README.md

+**2.** Add VMs or VMSS to Backend Pool:
+  - Manually add your Virtual Machines (VMs) or Virtual Machine Scale Sets (VMSS) to the Application Gateway’s backend pool as targets.
+
+**3.** Upgrade VM Instances:


This not is still valid

viktor-ribchev · 2024-11-05T09:05:03Z

README.md

+  - Path-Based Routing Rule: Set up a path-based routing rule on your Application Gateway to listen to the same context path. For example, if `context_path = "/graphdb"`, the path-based rule should be `/graphdb/*`.
+
+  _Note_:
+  - You can use your External Application Gateway without the context path.


External should be with lower case

viktor-ribchev · 2024-11-05T09:06:41Z

main.tf

  web_test_geo_locations            = var.web_test_geo_locations
  web_test_ssl_check_enabled        = var.web_test_ssl_check_enabled
-  graphdb_external_address_fqdn     = var.graphdb_external_address_fqdn != null ? var.graphdb_external_address_fqdn : module.application_gateway.public_ip_address_fqdn
+
+  #graphdb_external_address_fqdn     = var.graphdb_external_address_fqdn != null ? var.graphdb_external_address_fqdn : module.application_gateway.public_ip_address_fqdn


Do you need the commented line ?

not anymore. Removed. ty

viktor-ribchev · 2024-11-05T09:08:02Z

main.tf


  # App Configuration
  app_configuration_id       = module.appconfig.app_configuration_id
  app_configuration_endpoint = module.appconfig.app_configuration_endpoint

  # GraphDB Configurations
-  graphdb_external_address_fqdn = var.graphdb_external_address_fqdn != null ? var.graphdb_external_address_fqdn : module.application_gateway.public_ip_address_fqdn
+  graphdb_external_address_fqdn = var.graphdb_external_address_fqdn != null ? var.graphdb_external_address_fqdn : (var.disable_agw ? null : module.application_gateway[0].public_ip_address_fqdn)


I still want to see the outputted graphdb.properties file

modules/gateway/main.tf

kristianiliev1 · 2024-11-05T14:57:06Z

@viktor-ribchev I checked and everywhere else there is no empty line between for_each and content. Should I change it for all or keep it like this and eventually remove the spaces between Dynamic and for_each?

viktor-ribchev · 2024-11-06T05:17:52Z

@viktor-ribchev I checked and everywhere else there is no empty line between for_each and content. Should I change it for all or keep it like this and eventually remove the spaces between Dynamic and for_each?

Check what I've commented.

The empty line should be between for_each and content

remove null from variables terraform-docs: updated markdown table Update variables.tf Added Vik's suggestion terraform-docs: updated markdown table Password default back to Null variables.tf terraform-docs: updated markdown table Update Description for tls_certificate_path terraform-docs: updated markdown table Update variables.tf terraform-docs: updated markdown table fix typo variables.tf terraform-docs: updated markdown table Added missing default for tls_certificate_path terraform-docs: updated markdown table Update GraphDB default version to 10.7.6 terraform-docs: updated markdown table Add Variables File change for testing purposes terraform-docs: updated markdown table Add the rest of the changes test Fix comments from Viktor add validations for disable_agw and fix some comments add clarity on readme and variables Add the rest of the changes test Fix comments from Viktor Formated README.md Added some extra formatting for Readme Update README.md Added Viktor's suggestions Remove Bullet from README.md add changes, fix comments terraform-docs: updated markdown table Fix README.md Comments fix comments terraform-docs: updated markdown table Update README.md Fix comments from Viktor Add Note for external_fdqn formating Add Variables File change for testing purposes terraform-docs: updated markdown table Add the rest of the changes test Fix comments from Viktor Formated README.md Added some extra formatting for Readme Update README.md Added Viktor's suggestions Fix README.md Comments fix comments terraform-docs: updated markdown table

Password default back to Null variables.tf terraform-docs: updated markdown table Added missing default for tls_certificate_path terraform-docs: updated markdown table terraform-docs: updated markdown table fix git ignore + monitoring fix comments fix formating

remove null from variables terraform-docs: updated markdown table Update variables.tf Added Vik's suggestion terraform-docs: updated markdown table Password default back to Null variables.tf terraform-docs: updated markdown table Update Description for tls_certificate_path terraform-docs: updated markdown table Update variables.tf terraform-docs: updated markdown table fix typo variables.tf terraform-docs: updated markdown table Added missing default for tls_certificate_path terraform-docs: updated markdown table Update GraphDB default version to 10.7.6 terraform-docs: updated markdown table Add Variables File change for testing purposes terraform-docs: updated markdown table Add the rest of the changes test Fix comments from Viktor add validations for disable_agw and fix some comments add clarity on readme and variables Add the rest of the changes test Fix comments from Viktor Formated README.md Added some extra formatting for Readme Update README.md Added Viktor's suggestions Remove Bullet from README.md add changes, fix comments terraform-docs: updated markdown table Fix README.md Comments fix comments terraform-docs: updated markdown table Update README.md Fix comments from Viktor Add Note for external_fdqn formating Add Variables File change for testing purposes terraform-docs: updated markdown table Add the rest of the changes test Fix comments from Viktor Formated README.md Added some extra formatting for Readme Update README.md Added Viktor's suggestions Fix README.md Comments fix comments terraform-docs: updated markdown table

Password default back to Null variables.tf terraform-docs: updated markdown table Added missing default for tls_certificate_path terraform-docs: updated markdown table terraform-docs: updated markdown table fix git ignore + monitoring fix comments fix formating

rebase

modules/graphdb/templates/04_gdb_conf_overrides.sh.tpl

terraform-docs: updated markdown table remove null from variables terraform-docs: updated markdown table Update variables.tf Added Vik's suggestion terraform-docs: updated markdown table Password default back to Null variables.tf terraform-docs: updated markdown table Update Description for tls_certificate_path terraform-docs: updated markdown table Update variables.tf terraform-docs: updated markdown table fix typo variables.tf terraform-docs: updated markdown table Added missing default for tls_certificate_path terraform-docs: updated markdown table Update GraphDB default version to 10.7.6 terraform-docs: updated markdown table Add Variables File change for testing purposes terraform-docs: updated markdown table Add the rest of the changes test Fix comments from Viktor add validations for disable_agw and fix some comments add clarity on readme and variables Add the rest of the changes test Fix comments from Viktor Formated README.md Added some extra formatting for Readme Update README.md Added Viktor's suggestions Remove Bullet from README.md add changes, fix comments terraform-docs: updated markdown table Fix README.md Comments fix comments terraform-docs: updated markdown table Update README.md Fix comments from Viktor Add Note for external_fdqn formating Add Variables File change for testing purposes terraform-docs: updated markdown table Add the rest of the changes test Fix comments from Viktor Formated README.md Added some extra formatting for Readme Update README.md Added Viktor's suggestions Fix README.md Comments fix comments terraform-docs: updated markdown table comments fix + formating Password default back to Null variables.tf terraform-docs: updated markdown table Added missing default for tls_certificate_path terraform-docs: updated markdown table terraform-docs: updated markdown table fix git ignore + monitoring fix comments fix formating change changelog rebase add empty line

Fix documentation comments fix + formating Password default back to Null variables.tf terraform-docs: updated markdown table Added missing default for tls_certificate_path terraform-docs: updated markdown table terraform-docs: updated markdown table fix git ignore + monitoring fix comments fix formating change changelog rebase terraform-docs: updated markdown table fix comments. Add changes to changelog terraform-docs: updated markdown table remove null from variables terraform-docs: updated markdown table Update variables.tf Added Vik's suggestion terraform-docs: updated markdown table Password default back to Null variables.tf terraform-docs: updated markdown table Update Description for tls_certificate_path terraform-docs: updated markdown table Update variables.tf terraform-docs: updated markdown table fix typo variables.tf terraform-docs: updated markdown table Added missing default for tls_certificate_path terraform-docs: updated markdown table Update GraphDB default version to 10.7.6 terraform-docs: updated markdown table Add Variables File change for testing purposes terraform-docs: updated markdown table Add the rest of the changes test Fix comments from Viktor add validations for disable_agw and fix some comments add clarity on readme and variables Add the rest of the changes test Fix comments from Viktor Formated README.md Added some extra formatting for Readme Update README.md Added Viktor's suggestions Remove Bullet from README.md add changes, fix comments terraform-docs: updated markdown table Fix README.md Comments fix comments terraform-docs: updated markdown table Update README.md Fix comments from Viktor Add Note for external_fdqn formating Add Variables File change for testing purposes terraform-docs: updated markdown table Add the rest of the changes test Fix comments from Viktor Formated README.md Added some extra formatting for Readme Update README.md Added Viktor's suggestions Fix README.md Comments fix comments terraform-docs: updated markdown table comments fix + formating Password default back to Null variables.tf terraform-docs: updated markdown table Added missing default for tls_certificate_path terraform-docs: updated markdown table terraform-docs: updated markdown table fix git ignore + monitoring fix comments fix formating change changelog rebase add empty line fix documentation terraform-docs: updated markdown table Update default GraphDB version to 10.8.0 update documentation Updated default GraphDB Version 10.8.0 update documentation terraform-docs: updated markdown table terraform-docs: updated markdown table remove null from variables terraform-docs: updated markdown table Update variables.tf Added Vik's suggestion terraform-docs: updated markdown table Password default back to Null variables.tf terraform-docs: updated markdown table Update Description for tls_certificate_path terraform-docs: updated markdown table Update variables.tf terraform-docs: updated markdown table fix typo variables.tf terraform-docs: updated markdown table Added missing default for tls_certificate_path terraform-docs: updated markdown table Update GraphDB default version to 10.7.6 terraform-docs: updated markdown table Add Variables File change for testing purposes terraform-docs: updated markdown table Add the rest of the changes test Fix comments from Viktor add validations for disable_agw and fix some comments add clarity on readme and variables Add the rest of the changes test Fix comments from Viktor Formated README.md Added some extra formatting for Readme Update README.md Added Viktor's suggestions Remove Bullet from README.md add changes, fix comments terraform-docs: updated markdown table Fix README.md Comments fix comments terraform-docs: updated markdown table Update README.md Fix comments from Viktor Add Note for external_fdqn formating Add Variables File change for testing purposes terraform-docs: updated markdown table Add the rest of the changes test Fix comments from Viktor Formated README.md Added some extra formatting for Readme Update README.md Added Viktor's suggestions Fix README.md Comments fix comments terraform-docs: updated markdown table comments fix + formating Password default back to Null variables.tf terraform-docs: updated markdown table Added missing default for tls_certificate_path terraform-docs: updated markdown table terraform-docs: updated markdown table fix git ignore + monitoring fix comments fix formating Fix documentation change changelog rebase terraform-docs: updated markdown table fix comments. Add changes to changelog terraform-docs: updated markdown table remove null from variables terraform-docs: updated markdown table Update variables.tf Added Vik's suggestion terraform-docs: updated markdown table Password default back to Null variables.tf terraform-docs: updated markdown table Update Description for tls_certificate_path terraform-docs: updated markdown table Update variables.tf terraform-docs: updated markdown table fix typo variables.tf terraform-docs: updated markdown table Added missing default for tls_certificate_path terraform-docs: updated markdown table Update GraphDB default version to 10.7.6 terraform-docs: updated markdown table Add Variables File change for testing purposes terraform-docs: updated markdown table Add the rest of the changes test Fix comments from Viktor add validations for disable_agw and fix some comments add clarity on readme and variables Add the rest of the changes test Fix comments from Viktor Formated README.md Added some extra formatting for Readme Update README.md Added Viktor's suggestions Remove Bullet from README.md add changes, fix comments terraform-docs: updated markdown table Fix README.md Comments fix comments terraform-docs: updated markdown table Update README.md Fix comments from Viktor Add Note for external_fdqn formating Add Variables File change for testing purposes terraform-docs: updated markdown table Add the rest of the changes test Fix comments from Viktor Formated README.md Added some extra formatting for Readme Update README.md Added Viktor's suggestions Fix README.md Comments fix comments terraform-docs: updated markdown table comments fix + formating Password default back to Null variables.tf terraform-docs: updated markdown table Added missing default for tls_certificate_path terraform-docs: updated markdown table terraform-docs: updated markdown table fix git ignore + monitoring fix comments fix formating change changelog rebase add empty line terraform-docs: updated markdown table Fix documentation comments fix + formating Password default back to Null variables.tf terraform-docs: updated markdown table Added missing default for tls_certificate_path terraform-docs: updated markdown table terraform-docs: updated markdown table fix git ignore + monitoring fix comments fix formating change changelog rebase terraform-docs: updated markdown table fix comments. Add changes to changelog terraform-docs: updated markdown table remove null from variables terraform-docs: updated markdown table Update variables.tf Added Vik's suggestion terraform-docs: updated markdown table Password default back to Null variables.tf terraform-docs: updated markdown table Update Description for tls_certificate_path terraform-docs: updated markdown table Update variables.tf terraform-docs: updated markdown table fix typo variables.tf terraform-docs: updated markdown table Added missing default for tls_certificate_path terraform-docs: updated markdown table Update GraphDB default version to 10.7.6 terraform-docs: updated markdown table Add Variables File change for testing purposes terraform-docs: updated markdown table Add the rest of the changes test Fix comments from Viktor add validations for disable_agw and fix some comments add clarity on readme and variables Add the rest of the changes test Fix comments from Viktor Formated README.md Added some extra formatting for Readme Update README.md Added Viktor's suggestions Remove Bullet from README.md add changes, fix comments terraform-docs: updated markdown table Fix README.md Comments fix comments terraform-docs: updated markdown table Update README.md Fix comments from Viktor Add Note for external_fdqn formating Add Variables File change for testing purposes terraform-docs: updated markdown table Add the rest of the changes test Fix comments from Viktor Formated README.md Added some extra formatting for Readme Update README.md Added Viktor's suggestions Fix README.md Comments fix comments terraform-docs: updated markdown table comments fix + formating Password default back to Null variables.tf terraform-docs: updated markdown table Added missing default for tls_certificate_path terraform-docs: updated markdown table terraform-docs: updated markdown table fix git ignore + monitoring fix comments fix formating change changelog rebase add empty line fix documentation terraform-docs: updated markdown table Update default GraphDB version to 10.8.0 terraform-docs: updated markdown table Updated default GraphDB Version 10.8.0 change changelog rebase terraform-docs: updated markdown table fix comments. Add changes to changelog terraform-docs: updated markdown table remove null from variables terraform-docs: updated markdown table Update variables.tf Added Vik's suggestion terraform-docs: updated markdown table Password default back to Null variables.tf terraform-docs: updated markdown table Update Description for tls_certificate_path terraform-docs: updated markdown table Update variables.tf terraform-docs: updated markdown table fix typo variables.tf terraform-docs: updated markdown table Added missing default for tls_certificate_path terraform-docs: updated markdown table Update GraphDB default version to 10.7.6 terraform-docs: updated markdown table Add Variables File change for testing purposes terraform-docs: updated markdown table Add the rest of the changes test Fix comments from Viktor add validations for disable_agw and fix some comments add clarity on readme and variables Add the rest of the changes test Fix comments from Viktor Formated README.md Added some extra formatting for Readme Update README.md Added Viktor's suggestions Remove Bullet from README.md add changes, fix comments terraform-docs: updated markdown table Fix README.md Comments fix comments terraform-docs: updated markdown table Update README.md Fix comments from Viktor Add Note for external_fdqn formating Add Variables File change for testing purposes terraform-docs: updated markdown table Add the rest of the changes test Fix comments from Viktor Formated README.md Added some extra formatting for Readme Update README.md Added Viktor's suggestions Fix README.md Comments fix comments terraform-docs: updated markdown table comments fix + formating Password default back to Null variables.tf terraform-docs: updated markdown table Added missing default for tls_certificate_path terraform-docs: updated markdown table terraform-docs: updated markdown table fix git ignore + monitoring fix comments fix formating change changelog rebase add empty line terraform-docs: updated markdown table Fix documentation comments fix + formating Password default back to Null variables.tf terraform-docs: updated markdown table Added missing default for tls_certificate_path terraform-docs: updated markdown table terraform-docs: updated markdown table fix git ignore + monitoring fix comments fix formating change changelog rebase terraform-docs: updated markdown table fix comments. Add changes to changelog terraform-docs: updated markdown table remove null from variables terraform-docs: updated markdown table Update variables.tf Added Vik's suggestion terraform-docs: updated markdown table Password default back to Null variables.tf terraform-docs: updated markdown table Update Description for tls_certificate_path terraform-docs: updated markdown table Update variables.tf terraform-docs: updated markdown table fix typo variables.tf terraform-docs: updated markdown table Added missing default for tls_certificate_path terraform-docs: updated markdown table Update GraphDB default version to 10.7.6 terraform-docs: updated markdown table Add Variables File change for testing purposes terraform-docs: updated markdown table Add the rest of the changes test Fix comments from Viktor add validations for disable_agw and fix some comments add clarity on readme and variables Add the rest of the changes test Fix comments from Viktor Formated README.md Added some extra formatting for Readme Update README.md Added Viktor's suggestions Remove Bullet from README.md add changes, fix comments terraform-docs: updated markdown table Fix README.md Comments fix comments terraform-docs: updated markdown table Update README.md Fix comments from Viktor Add Note for external_fdqn formating Add Variables File change for testing purposes terraform-docs: updated markdown table Add the rest of the changes test Fix comments from Viktor Formated README.md Added some extra formatting for Readme Update README.md Added Viktor's suggestions Fix README.md Comments fix comments terraform-docs: updated markdown table comments fix + formating Password default back to Null variables.tf terraform-docs: updated markdown table Added missing default for tls_certificate_path terraform-docs: updated markdown table terraform-docs: updated markdown table fix git ignore + monitoring fix comments fix formating change changelog rebase add empty line fix documentation terraform-docs: updated markdown table Update default GraphDB version to 10.8.0 update documentation Updated default GraphDB Version 10.8.0 update documentation terraform-docs: updated markdown table terraform-docs: updated markdown table remove null from variables terraform-docs: updated markdown table Update variables.tf Added Vik's suggestion terraform-docs: updated markdown table Password default back to Null variables.tf terraform-docs: updated markdown table Update Description for tls_certificate_path terraform-docs: updated markdown table Update variables.tf terraform-docs: updated markdown table fix typo variables.tf terraform-docs: updated markdown table Added missing default for tls_certificate_path terraform-docs: updated markdown table Update GraphDB default version to 10.7.6 terraform-docs: updated markdown table Add Variables File change for testing purposes terraform-docs: updated markdown table Add the rest of the changes test Fix comments from Viktor add validations for disable_agw and fix some comments add clarity on readme and variables Add the rest of the changes test Fix comments from Viktor Formated README.md Added some extra formatting for Readme Update README.md Added Viktor's suggestions Remove Bullet from README.md add changes, fix comments terraform-docs: updated markdown table Fix README.md Comments fix comments terraform-docs: updated markdown table Update README.md Fix comments from Viktor Add Note for external_fdqn formating Add Variables File change for testing purposes terraform-docs: updated markdown table Add the rest of the changes test Fix comments from Viktor Formated README.md Added some extra formatting for Readme Update README.md Added Viktor's suggestions Fix README.md Comments fix comments terraform-docs: updated markdown table comments fix + formating Password default back to Null variables.tf terraform-docs: updated markdown table Added missing default for tls_certificate_path terraform-docs: updated markdown table terraform-docs: updated markdown table fix git ignore + monitoring fix comments fix formating Fix documentation change changelog rebase terraform-docs: updated markdown table fix comments. Add changes to changelog terraform-docs: updated markdown table remove null from variables terraform-docs: updated markdown table Update variables.tf Added Vik's suggestion terraform-docs: updated markdown table Password default back to Null variables.tf terraform-docs: updated markdown table Update Description for tls_certificate_path terraform-docs: updated markdown table Update variables.tf terraform-docs: updated markdown table fix typo variables.tf terraform-docs: updated markdown table Added missing default for tls_certificate_path terraform-docs: updated markdown table Update GraphDB default version to 10.7.6 terraform-docs: updated markdown table Add Variables File change for testing purposes terraform-docs: updated markdown table Add the rest of the changes test Fix comments from Viktor add validations for disable_agw and fix some comments add clarity on readme and variables Add the rest of the changes test Fix comments from Viktor Formated README.md Added some extra formatting for Readme Update README.md Added Viktor's suggestions Remove Bullet from README.md add changes, fix comments terraform-docs: updated markdown table Fix README.md Comments fix comments terraform-docs: updated markdown table Update README.md Fix comments from Viktor Add Note for external_fdqn formating Add Variables File change for testing purposes terraform-docs: updated markdown table Add the rest of the changes test Fix comments from Viktor Formated README.md Added some extra formatting for Readme Update README.md Added Viktor's suggestions Fix README.md Comments fix comments terraform-docs: updated markdown table comments fix + formating Password default back to Null variables.tf terraform-docs: updated markdown table Added missing default for tls_certificate_path terraform-docs: updated markdown table terraform-docs: updated markdown table fix git ignore + monitoring fix comments fix formating change changelog rebase add empty line terraform-docs: updated markdown table Fix documentation comments fix + formating Password default back to Null variables.tf terraform-docs: updated markdown table Added missing default for tls_certificate_path terraform-docs: updated markdown table terraform-docs: updated markdown table fix git ignore + monitoring fix comments fix formating change changelog rebase terraform-docs: updated markdown table fix comments. Add changes to changelog terraform-docs: updated markdown table remove null from variables terraform-docs: updated markdown table Update variables.tf Added Vik's suggestion terraform-docs: updated markdown table Password default back to Null variables.tf terraform-docs: updated markdown table Update Description for tls_certificate_path terraform-docs: updated markdown table Update variables.tf terraform-docs: updated markdown table fix typo variables.tf terraform-docs: updated markdown table Added missing default for tls_certificate_path terraform-docs: updated markdown table Update GraphDB default version to 10.7.6 terraform-docs: updated markdown table Add Variables File change for testing purposes terraform-docs: updated markdown table Add the rest of the changes test Fix comments from Viktor add validations for disable_agw and fix some comments add clarity on readme and variables Add the rest of the changes test Fix comments from Viktor Formated README.md Added some extra formatting for Readme Update README.md Added Viktor's suggestions Remove Bullet from README.md add changes, fix comments terraform-docs: updated markdown table Fix README.md Comments fix comments terraform-docs: updated markdown table Update README.md Fix comments from Viktor Add Note for external_fdqn formating Add Variables File change for testing purposes terraform-docs: updated markdown table Add the rest of the changes test Fix comments from Viktor Formated README.md Added some extra formatting for Readme Update README.md Added Viktor's suggestions Fix README.md Comments fix comments terraform-docs: updated markdown table comments fix + formating Password default back to Null variables.tf terraform-docs: updated markdown table Added missing default for tls_certificate_path terraform-docs: updated markdown table terraform-docs: updated markdown table fix git ignore + monitoring fix comments fix formating change changelog rebase add empty line fix documentation terraform-docs: updated markdown table add changes in changelog

kristianiliev1 requested review from viktor-ribchev and yaskoo October 3, 2024 11:47

viktor-ribchev reviewed Oct 8, 2024

View reviewed changes

kristianiliev1 changed the title ~~Add Variables File change for testing purposes~~ GDB-10856 - Add Variables File change for testing purposes Oct 8, 2024

viktor-ribchev reviewed Oct 10, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

viktor-ribchev reviewed Oct 11, 2024

View reviewed changes

kristianiliev1 marked this pull request as ready for review October 11, 2024 11:51

viktor-ribchev reviewed Oct 21, 2024

View reviewed changes

modules/gateway/outputs.tf Outdated Show resolved Hide resolved

modules/gateway/variables.tf Outdated Show resolved Hide resolved

output.tf Show resolved Hide resolved

viktor-ribchev reviewed Oct 21, 2024

View reviewed changes

viktor-ribchev reviewed Oct 22, 2024

View reviewed changes

kristianiliev1 requested a review from simonzhekoff October 28, 2024 08:05

kristianiliev1 changed the title ~~GDB-10856 - Add Variables File change for testing purposes~~ GDB-10856-Add-External-AGW Oct 28, 2024

viktor-ribchev reviewed Oct 28, 2024

View reviewed changes

kristianiliev1 force-pushed the GDB-10856-NO-AGW-NEW-BRANCH branch 6 times, most recently from 57146ac to 727bb13 Compare October 31, 2024 14:52

simonzhekoff reviewed Nov 5, 2024

View reviewed changes

variables.tf Show resolved Hide resolved

viktor-ribchev reviewed Nov 5, 2024

View reviewed changes

viktor-ribchev changed the title ~~GDB-10856-Add-External-AGW~~ [GDB-10856] Add External AGW and context path support Nov 5, 2024

viktor-ribchev changed the title ~~[GDB-10856] Add External AGW and context path support~~ [GDB-10856] Added External AGW and context path support Nov 5, 2024

kristianiliev1 force-pushed the GDB-10856-NO-AGW-NEW-BRANCH branch 2 times, most recently from 945835c to ae043df Compare November 7, 2024 17:26

github-actions bot and others added 9 commits November 11, 2024 10:09

comments fix + formating

92497fb

Password default back to Null variables.tf terraform-docs: updated markdown table Added missing default for tls_certificate_path terraform-docs: updated markdown table terraform-docs: updated markdown table fix git ignore + monitoring fix comments fix formating

remove null from variables

9e37766

Password default back to Null variables.tf

e356d10

Update GraphDB default version to 10.7.6

7365cba

terraform-docs: updated markdown table

137b501

comments fix + formating

81d79fb

Password default back to Null variables.tf terraform-docs: updated markdown table Added missing default for tls_certificate_path terraform-docs: updated markdown table terraform-docs: updated markdown table fix git ignore + monitoring fix comments fix formating

change changelog

68e72ff

rebase

kristianiliev1 force-pushed the GDB-10856-NO-AGW-NEW-BRANCH branch from c1ba3fe to 68e72ff Compare November 11, 2024 08:16

terraform-docs: updated markdown table

c7980ef

simonzhekoff reviewed Nov 11, 2024

View reviewed changes

modules/graphdb/templates/04_gdb_conf_overrides.sh.tpl Show resolved Hide resolved

github-actions bot added 2 commits November 11, 2024 16:39

kristianiliev1 force-pushed the GDB-10856-NO-AGW-NEW-BRANCH branch from 424288a to 0010028 Compare November 19, 2024 13:35

simonzhekoff closed this Dec 3, 2024

simonzhekoff deleted the GDB-10856-NO-AGW-NEW-BRANCH branch December 3, 2024 09:58

		@@ -1,5 +1,13 @@
		# GraphDB Azure Terraform Module Changelog

		## 1.3.4


		_Example Configuration:_
		Example Configuration:

[GDB-10856] Added External AGW and context path support #91

[GDB-10856] Added External AGW and context path support #91

Conversation

kristianiliev1 commented Oct 3, 2024 • edited by jira bot Loading

Description

Related Issues

Changes

Screenshots (if applicable)

Checklist

viktor-ribchev commented Oct 8, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

viktor-ribchev commented Oct 8, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

viktor-ribchev commented Oct 28, 2024

Choose a reason for hiding this comment

viktor-ribchev commented Oct 28, 2024

simonzhekoff commented Nov 5, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kristianiliev1 commented Nov 5, 2024

viktor-ribchev commented Nov 6, 2024

kristianiliev1 commented Oct 3, 2024 •

edited by jira bot

Loading