-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[projmgr] Add --frozen-packs argument to csolution #1225
[projmgr] Add --frozen-packs argument to csolution #1225
Conversation
4ba3169
to
e5eced6
Compare
@Torbjorn-Svensson, is this PR ready for review or in Draft? |
As we discusses on the meetings the previous 2 weeks, this was the followup PR that should preferably be included in the 2.2.0 release, but was "optional" in case time did not allow to make it stable. |
Alternative names for the option I can think of are:
similar to rte file update:
|
I do not have any strict opinion on what it should be named, but I think it would be best if it's not confused with what |
This PR can make use of "Dedicated method to Update RTE folder" #1244 |
In the technical meeting from 2023-12-05 we agreed to use the command line option:
|
e5eced6
to
aaa5502
Compare
@edriouk Can you please take a look at the 2nd commit in this PR as it appears to fix the issue that I talked about in the meeting today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Torbjorn-Svensson, I need more information about the change in RteProject.cpp.
To my understanding, --frozen-packs argument is used against already converted projects all config files are already copied to the RTE directory and all @base files are created.
Could you explain the case you are trying to fix?
@brondani, could you please approve the rest.
07e4169
to
3c48651
Compare
3c48651
to
cd14022
Compare
When resolving the base file version for RTE files when the RTE directory has not yet been populated, fall back to the version defined in the pack. Contributed by STMicroelectronics Signed-off-by: Torbjörn SVENSSON <[email protected]> Co-authored-by: Samuel HULTGREN <[email protected]>
The --frozen-packs option is only applicable for the following commands: - convert - update-rte If cbuild-pack.yml needs to be created or updated, then --frozen-pack will treat this as an error and fail the command. Contributed by STMicroelectronics Signed-off-by: Torbjörn SVENSSON <[email protected]>
cd14022
to
a39244d
Compare
Rebased on projmgr/2.2.1. There should be no more changes needed before this PR can be merged. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1225 +/- ##
==========================================
+ Coverage 59.20% 59.22% +0.02%
==========================================
Files 117 117
Lines 23564 23578 +14
Branches 13106 13116 +10
==========================================
+ Hits 13951 13965 +14
Misses 7348 7348
Partials 2265 2265
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Torbjorn-Svensson Thanks for the contribution.
LGTM
The
--frozen-packs
option is only applicable for the following commands:convert
update-rte
If
cbuild-pack.yml
needs to be created or updated, then--frozen-pack
will treat this as an error and fail the command.Contributed by STMicroelectronics