Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[projmgr] Don't consider cbuild-pack.yml with --load <all|latest> (#1291) #1302

Conversation

Torbjorn-Svensson
Copy link
Collaborator

When --load all or --load latest argument is provided, the content of cbuild-pack.yml files should not be considered, but the file should be updated with the new resolved packs.

Contributed by STMicroelectronics

…en-CMSIS-Pack#1291)

When `--load all` or `--load latest` argument is provided, the content
of `cbuild-pack.yml` files should not be considered, but the file
should be updated with the new resolved packs.

Contributed by STMicroelectronics

Signed-off-by: Torbjörn SVENSSON <[email protected]>
@jkrech jkrech requested review from edriouk and brondani January 30, 2024 13:12
@jkrech jkrech linked an issue Jan 30, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Jan 30, 2024

Test Results

  3 files   18 suites   4m 23s ⏱️
310 tests 310 ✅ 0 💤 0 ❌
930 runs  930 ✅ 0 💤 0 ❌

Results for commit 2462c77.

♻️ This comment has been updated with latest results.

@Torbjorn-Svensson Torbjorn-Svensson force-pushed the pr/cbuild-pack-with-load-all-or-load-latest branch from 37e2aee to 2462c77 Compare January 30, 2024 13:18
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a5bd02e) 59.26% compared to head (2462c77) 59.26%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1302   +/-   ##
=======================================
  Coverage   59.26%   59.26%           
=======================================
  Files         117      117           
  Lines       23549    23550    +1     
  Branches    13116    13117    +1     
=======================================
+ Hits        13956    13958    +2     
  Misses       7338     7338           
+ Partials     2255     2254    -1     
Flag Coverage Δ
projmgr-cov 84.63% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
tools/projmgr/src/ProjMgrWorker.cpp 84.94% <100.00%> (+0.03%) ⬆️

@brondani brondani removed the request for review from edriouk January 31, 2024 12:24
Copy link
Collaborator

@brondani brondani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Torbjorn-Svensson Thanks for the contribution.
LGTM

@brondani brondani merged commit 5572be9 into Open-CMSIS-Pack:main Jan 31, 2024
33 checks passed
@Torbjorn-Svensson Torbjorn-Svensson deleted the pr/cbuild-pack-with-load-all-or-load-latest branch January 31, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[csolution] Clarify precedence of controls for pack version selection
2 participants