[projmgr] Strip build metadata when handling pack versions #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1382 +/- ##
==========================================
+ Coverage 59.18% 59.20% +0.01%
==========================================
Files 117 117
Lines 23447 23456 +9
Branches 13100 13108 +8
==========================================
+ Hits 13878 13887 +9
Misses 7310 7310
Partials 2259 2259
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Test Results 33 files 66 suites 4s ⏱️ Results for commit 446f0ff. ♻️ This comment has been updated with latest results. |
jkrech
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strip build metadata when handling pack versions.
Throw a warning when specified metadata does not match the one from the loaded pack.
Addresses #1339 (comment)