Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[devtools] Extend language-C and language-CPP supported values #1799

Merged

Conversation

EaselinkBachmann
Copy link
Contributor

This PR adds the remaining missing C and C++ language standards to AC6, GCC, and CLANG.

  • add C standards gnu17 and gnu23
  • add C++ standards c++23 and gnu++23
  • fix C++ standards c++20 and gnu++20 incorrectly setting -std=c++17 and -std=gnu++17 on AC6

Fixes #1785

@jkrech jkrech requested a review from brondani October 15, 2024 10:28
Copy link

github-actions bot commented Oct 15, 2024

Test Results

  7 files   53 suites   4m 14s ⏱️
185 tests 168 ✅ 17 💤 0 ❌
692 runs  624 ✅ 68 💤 0 ❌

Results for commit da38061.

♻️ This comment has been updated with latest results.

@EaselinkBachmann EaselinkBachmann force-pushed the feature/new-language-standards branch from 146061e to 2d20940 Compare October 17, 2024 10:45
@EaselinkBachmann EaselinkBachmann force-pushed the feature/new-language-standards branch from 2d20940 to da38061 Compare October 22, 2024 09:15
Copy link
Collaborator

@brondani brondani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brondani brondani merged commit f955320 into Open-CMSIS-Pack:main Oct 23, 2024
55 checks passed
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.92%. Comparing base (2f01ab2) to head (da38061).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1799   +/-   ##
=======================================
  Coverage   64.92%   64.92%           
=======================================
  Files         163      163           
  Lines       34453    34453           
  Branches    19975    19975           
=======================================
  Hits        22367    22367           
- Misses       7900     7918   +18     
+ Partials     4186     4168   -18     
Flag Coverage Δ
buildmgr-cov 73.94% <ø> (ø)
projmgr-cov 81.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

@EaselinkBachmann EaselinkBachmann deleted the feature/new-language-standards branch October 24, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C and C++ language standards support is inconsistent and missing some standards versions
2 participants