Skip to content

New ML Algorithm (Naive Bayes ) implementation with test cases #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Coder1010ayush
Copy link

Good Evening Sir, This is my first open source pull request in an open source repository. I have implemented Naive Bayes classifier. I would be grateful if you could review it at your convenience and share any feedback or suggestions for further improvement.

@moe18
Copy link
Collaborator

moe18 commented May 25, 2025

This looks really good! but I would split it up into multiple PRs one for each bayes method
test_bernoulli_naive_bayes()
test_gaussian_naive_bayes()
test_multinomial_naive_bayes()
test_gaussian_nb()
test_binary_nb()
test_multinomial_nb()

@Coder1010ayush
Copy link
Author

Thank you for replying , i will split it into three section by tommorrow.

@Coder1010ayush
Copy link
Author

i have split it into three folder 113_naive_bayes_bernauli ,114_naive_bayes_gaussian , 115_naive_bayes_multinomial.

test_gaussian_nb()
test_binary_nb()
test_multinomial_nb() , all these were part of this only

test_bernoulli_naive_bayes()
test_gaussian_naive_bayes()
test_multinomial_naive_bayes()

so i have done like this. Please review this and suggest if there is any issue.

for the future use $$ and $ for formulas, for now I made the fix
Copy link
Collaborator

@moe18 moe18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first one looks good, still going through the rest

@Coder1010ayush
Copy link
Author

Thanks for taking a look! Glad the first one is okay. I’ll stand by for any feedback on the remaining tests—just let me know if you spot anything that needs tweaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants