Skip to content

Problem7 testcase4 bugfix #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bigfoot1144
Copy link

Problem

image

Where the equation does not need S to be invertible. Which causes further confusion in the "learn about this topic" page. Where they only check for invertibility of T because that's the only place its necessary to solve the equation.

image
image

solution

  • Remove check for invertibility of S
  • change problem 4 edge case to make T determinant 0.
  • Also change verbiage of the problem to reflect that only T needs invertibility check. (Not possible through PR I think?)

@BjBodner
Copy link
Contributor

BjBodner commented Apr 7, 2025

Hi, totally agree with your assessment in the context of the minimal requirements for this code to run. However, since A can be full rank, if S is not invertible, this means that this transformation will reduce the rank of the resulting matrix, making it IRREVERSIBLE.
Usually, such transformations are required to be REVERSIBLE, which can only happen if BOTH S and T are invertible. This is kinda similar to applying a rotation matrix to a vector, however, here we are "rotating" a matrix.

Perhaps it would be worth mentioning this in the description of the question, that this is what we are trying to do: "apply a REVERSIBLE transformation to A", since in the current formulation it is not clear, and then your proposal totally makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants