Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v2.0.4 for OCPN5.6.2 #841

Merged
merged 2 commits into from
Mar 14, 2023
Merged

Update to v2.0.4 for OCPN5.6.2 #841

merged 2 commits into from
Mar 14, 2023

Conversation

antipole2
Copy link
Contributor

Allows push of NMEA data starting !

@antipole2
Copy link
Contributor Author

Dave - error is in target name. I wrote in Zulip..

Secondly, I need to leave the wx315 files in the catalogue for OCPN5.6 but the darwin xml contained target of darwin-wx315, which is no longer accepted during checks after the pull request. It seems the options are now darwin & darwin-32. So I edited the target in the xml file to darwin and PRd again. It passed checks this time.

to which Alec said

You should not make that edit. Instead, leave it as-is and make a notd to Dave why the check fails. He is aware of the situation, and will merge anyway. Changing the target to wx-32 passes the checks, but might crash in runtime since these old plugins actually are linked against wx 3.1.5

@bdbcat
Copy link
Member

bdbcat commented Mar 14, 2023

@leamas:
Why not revert the XSD, and add back darwin-wx315? For just this sort of case, maintenance of plugins for O562.

@leamas
Copy link
Contributor

leamas commented Mar 14, 2023

Because if we did, we would approve wx-315 plugins for 5.7/5.8. That is, better a false positive than a false negative.

I see no solution besides actually deal with #818, but this is IMHO way to late in this cycle.

@bdbcat
Copy link
Member

bdbcat commented Mar 14, 2023

OK, I see that. sigh....
Thanks

@bdbcat bdbcat merged commit fc5bc9c into OpenCPN:master Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants