Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] add action to remove entity from draft (#6728) #9684

Merged
merged 32 commits into from
Feb 6, 2025

Conversation

JeremyCloarec
Copy link
Contributor

@JeremyCloarec JeremyCloarec commented Jan 22, 2025

Linked PR: OpenCTI-Platform/client-python#824

Proposed changes

  • add mutation & background task action to remove current entity changes from draft
  • re-enable background tasks in draft
  • clean up draft_ids from works when draft is deleted
  • add draft chip & draft color to relationships

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 16.86391% with 281 lines in your changes missing coverage. Please review.

Project coverage is 64.72%. Comparing base (1442c72) to head (fe8df6a).
Report is 8 commits behind head on release/6.6.0.

Files with missing lines Patch % Lines
...tform/opencti-graphql/src/database/draft-engine.js 5.08% 168 Missing ⚠️
...ti-platform/opencti-graphql/src/database/engine.js 8.57% 64 Missing ⚠️
...atform/opencti-graphql/src/database/draft-utils.js 38.46% 16 Missing ⚠️
...tform/opencti-graphql/src/domain/stixCoreObject.js 11.11% 8 Missing ⚠️
...opencti-graphql/src/domain/stixCoreRelationship.js 11.11% 8 Missing ⚠️
...cti-graphql/src/domain/stixSightingRelationship.js 11.11% 8 Missing ⚠️
...rc/modules/draftWorkspace/draftWorkspace-domain.ts 77.77% 4 Missing ⚠️
...cti-platform/opencti-graphql/src/database/redis.ts 75.00% 2 Missing ⚠️
...latform/opencti-graphql/src/manager/taskManager.js 33.33% 2 Missing ⚠️
...rm/opencti-graphql/src/resolvers/stixCoreObject.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           release/6.6.0    #9684      +/-   ##
=================================================
+ Coverage          64.29%   64.72%   +0.42%     
=================================================
  Files                655      655              
  Lines              62909    63291     +382     
  Branches            6966     7480     +514     
=================================================
+ Hits               40450    40965     +515     
+ Misses             22459    22326     -133     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeremyCloarec JeremyCloarec changed the base branch from release/6.5.0 to release/6.6.0 February 6, 2025 08:39
@JeremyCloarec JeremyCloarec changed the title [backend] chunk8 [backend] add action to remove entity from draft (#6728) Feb 6, 2025
@JeremyCloarec JeremyCloarec marked this pull request as ready for review February 6, 2025 16:46
@JeremyCloarec JeremyCloarec merged commit c9986a7 into release/6.6.0 Feb 6, 2025
2 of 3 checks passed
@JeremyCloarec JeremyCloarec deleted the issue/6728chunk8 branch February 6, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants