fix issue 398 #verification #sonar #docs

OpenCyphal-Garage · Nov 29, 2024 · 215b27c · 215b27c
1 parent ade0d04
commit 215b27c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/include/libcyphal/executor.hpp b/include/libcyphal/executor.hpp
@@ -23,7 +23,7 @@ namespace libcyphal
 
 /// @brief Defines an abstract interface for a callback executor.
 ///
-class IExecutor : public ITimeProvider
+class IExecutor : public cetl::rtti::rtti, public ITimeProvider
 {
     // EBAF7312-5CFE-45F5-89FF-D9B9FE45F8EB
     // clang-format off
@@ -105,7 +105,7 @@ class IExecutor : public ITimeProvider
         ///
         static constexpr std::size_t MaxSize = (sizeof(void*) * 16) + sizeof(Function);
 
-        class Interface
+        class Interface : public rtti
         {
             // 5E16E6BC-C7EB-42EC-8A98-06189C2F0349
             // clang-format off
@@ -139,13 +139,13 @@ class IExecutor : public ITimeProvider
             }
 
             // No Sonar `cpp:S5008` and `cpp:S5356` b/c they are unavoidable - RTTI integration.
-            CETL_NODISCARD void* _cast_(const cetl::type_id& id) & noexcept  // NOSONAR cpp:S5008
+            CETL_NODISCARD void* _cast_(const cetl::type_id& id) & noexcept override  // NOSONAR cpp:S5008
             {
                 return (id == _get_type_id_()) ? this : nullptr;  // NOSONAR cpp:S5356
             }
 
             // No Sonar `cpp:S5008` and `cpp:S5356` b/c they are unavoidable - RTTI integration.
-            CETL_NODISCARD const void* _cast_(const cetl::type_id& id) const& noexcept  // NOSONAR cpp:S5008
+            CETL_NODISCARD const void* _cast_(const cetl::type_id& id) const& noexcept override  // NOSONAR cpp:S5008
             {
                 return (id == _get_type_id_()) ? this : nullptr;  // NOSONAR cpp:S5356
             }
@@ -240,13 +240,13 @@ class IExecutor : public ITimeProvider
     }
 
     // No Sonar `cpp:S5008` and `cpp:S5356` b/c they are unavoidable - RTTI integration.
-    CETL_NODISCARD virtual void* _cast_(const cetl::type_id& id) & noexcept  // NOSONAR cpp:S5008
+    CETL_NODISCARD void* _cast_(const cetl::type_id& id) & noexcept override  // NOSONAR cpp:S5008
     {
         return (id == _get_type_id_()) ? this : nullptr;  // NOSONAR cpp:S5356
     }
 
     // No Sonar `cpp:S5008` and `cpp:S5356` b/c they are unavoidable - RTTI integration.
-    CETL_NODISCARD virtual const void* _cast_(const cetl::type_id& id) const& noexcept  // NOSONAR cpp:S5008
+    CETL_NODISCARD const void* _cast_(const cetl::type_id& id) const& noexcept override  // NOSONAR cpp:S5008
     {
         return (id == _get_type_id_()) ? this : nullptr;  // NOSONAR cpp:S5356
     }

diff --git a/include/libcyphal/transport/scattered_buffer.hpp b/include/libcyphal/transport/scattered_buffer.hpp
@@ -35,7 +35,7 @@ class ScatteredBuffer final  // NOSONAR : cpp:S4963 - we do directly handle reso
     ///
     /// @see ScatteredBuffer::ScatteredBuffer(AnyStorage&& any_storage)
     ///
-    class IStorage
+    class IStorage : public cetl::rtti::rtti
     {
         // 91C1B109-F90E-45BE-95CF-6ED02AC3FFAA
         // clang-format off
@@ -78,13 +78,13 @@ class ScatteredBuffer final  // NOSONAR : cpp:S4963 - we do directly handle reso
         }
 
         // No Sonar `cpp:S5008` and `cpp:S5356` b/c they are unavoidable - RTTI integration.
-        CETL_NODISCARD void* _cast_(const cetl::type_id& id) & noexcept  // NOSONAR cpp:S5008
+        CETL_NODISCARD void* _cast_(const cetl::type_id& id) & noexcept override  // NOSONAR cpp:S5008
         {
             return (id == _get_type_id_()) ? this : nullptr;  // NOSONAR cpp:S5356
         }
 
         // No Sonar `cpp:S5008` and `cpp:S5356` b/c they are unavoidable - RTTI integration.
-        CETL_NODISCARD const void* _cast_(const cetl::type_id& id) const& noexcept  // NOSONAR cpp:S5008
+        CETL_NODISCARD const void* _cast_(const cetl::type_id& id) const& noexcept override  // NOSONAR cpp:S5008
         {
             return (id == _get_type_id_()) ? this : nullptr;  // NOSONAR cpp:S5356
         }